bug#73527: 30.0.90; Comint rebinds C-d

bug#73527: 30.0.90; Comint rebinds C-d

[Augusto Stoffel]

comint-mode rebinds C-d (to `comint-delchar-or-maybe-eof') in a way that
is supposed to fall back to the default C-d behavior unless point is on
a blank input line.

If the user rebinds C-d in the global map, e.g. to something sensible
such as `delete-forward-char', this preference is overridden.

Should a menu-item with :filter property be used instead in
comint-mode-map?

bug#73527: 30.0.90; Comint rebinds C-d

[Juri Linkov]

> comint-mode rebinds C-d (to `comint-delchar-or-maybe-eof') in a way that
> is supposed to fall back to the default C-d behavior unless point is on
> a blank input line.
>
> If the user rebinds C-d in the global map, e.g. to something sensible
> such as `delete-forward-char', this preference is overridden.
>
> Should a menu-item with :filter property be used instead in
> comint-mode-map?

It would be nice to make such filter customizable.

For example, currently I have to use:

  (define-key shell-mode-map "\C-d" 'my-shell-c-d)
  (defun my-shell-c-d (&optional arg)
    (interactive "p")
    (cond ((and (eobp)
                (save-excursion
                  (let ((inhibit-field-text-motion t))
                    (goto-char (line-beginning-position))
                    (looking-at-p "^iex.*>\s*$"))))
           (let ((process (get-buffer-process (current-buffer))))
             (process-send-string process ":init.stop()\n")))
          ((and (eobp)
                (save-excursion
                  (let ((inhibit-field-text-motion t))
                    (goto-char (line-beginning-position))
                    (looking-at-p "^[a-z:]*cljs\\..*=>\s*$"))))
           (let ((process (get-buffer-process (current-buffer))))
             (process-send-string process ":cljs/quit\n")))
          (t
           (comint-delchar-or-maybe-eof arg))))

But with a filter all these cases could be moved to the filter predicate,
along with its default value extracted from 'comint-delchar-or-maybe-eof':

    (if (and (eobp) proc (= (point) (marker-position (process-mark proc))))
	(comint-send-eof)
      (delete-char arg))

Then rebinding `C-d' from `delete-char' to `delete-forward-char'
will be handled automatically.

Also for the users of `delete-selection-mode' this will remove
the need to add more settings:

  (put 'comint-delchar-or-maybe-eof 'delete-selection 'supersede)
  (put 'my-shell-c-d 'delete-selection 'supersede)

according to this part of delsel.el:

  ;; delete-backward-char and delete-forward-char already delete the selection by
  ;; default, but not delete-char.
  (put 'delete-char 'delete-selection 'supersede)

bug#73527: 30.0.90; Comint rebinds C-d

[Augusto Stoffel]

On Sun, 29 Sep 2024 at 19:08, Juri Linkov wrote:

> It would be nice to make such filter customizable.
>
> For example, currently I have to use:
>
>   (define-key shell-mode-map "\C-d" 'my-shell-c-d)
>   (defun my-shell-c-d (&optional arg)
> [...]

Good point.  How about replacing (delete-char arg) in
comint-delchar-or-maybe-eof with

  (call-interactively
    (lookup-key global-map <something appropriate>))

Not sure this could be made to work reliably.