unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 74140@debbugs.gnu.org, ultrono@gmail.com
Subject: bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package
Date: Wed, 04 Dec 2024 14:08:43 +0200	[thread overview]
Message-ID: <86cyi71whg.fsf@gnu.org> (raw)
In-Reply-To: <878qswab57.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 03 Dec 2024 20:12:36 +0200)

> Cc: 74140@debbugs.gnu.org
> From: Juri Linkov <juri@linkov.net>
> Date: Tue, 03 Dec 2024 20:12:36 +0200
> 
> > So below is a patch that adds support for a list of maps.
> > And users don't have to populate the list manually because
> > 'defvar-keymap' does this automatically with :continue-only
> > in the same patch.
> 
> Now this patch is pushed, so you can use the new property
> to implement the :continue-only directive in bind-keys.

Thanks, but I think the NEWS entry needs a small clarification:

   ** New symbol property 'repeat-continue-only' for 'repeat-mode'.
  -A command with this symbol property whose value is non-nil will not
  -activate the repeat map in 'repeat-mode', it will only continue the
  -already activated repeating sequence.
  +A command with this symbol property whose value is a list of repeat
  +maps will not activate the repeat map in 'repeat-mode'.  It will only
  +continue the already activated repeating sequence.  Also 'defvar-keymap'
  +supports a new keyword ':continue-only' with a list of commands that
  +only continue the active repeating sequence.

This doesn't say what is the significance of the repeat maps included
in the value of the property (as opposed to those not included).  I'm
guessing they have some influence on the result, so NEWS should at
least hint on that.





  parent reply	other threads:[~2024-12-04 12:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 17:36 bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package Paul Nelson
2024-11-01  7:54 ` Juri Linkov
2024-11-01  8:29   ` Paul Nelson
2024-11-01  8:58     ` Paul Nelson
2024-11-04 19:22       ` Juri Linkov
2024-11-04 20:45         ` Paul Nelson
2024-11-05 18:25           ` Juri Linkov
2024-11-05 20:51             ` Paul Nelson
2024-11-07 19:41               ` Juri Linkov
2024-11-23 18:44                 ` Paul Nelson
2024-11-27  7:46                   ` Juri Linkov
2024-11-27 15:19                     ` Paul Nelson
2024-11-28 19:12                       ` Juri Linkov
2024-12-03 18:12                         ` Juri Linkov
2024-12-03 18:18                           ` Paul Nelson
2024-12-04 12:08                           ` Eli Zaretskii [this message]
2024-12-04 17:29                             ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86cyi71whg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74140@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=ultrono@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).