From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51173: 28.0.60; gnus-article-describe-key doesn't work Date: Tue, 30 Nov 2021 10:54:27 +0200 Organization: LINKOV.NET Message-ID: <86bl22f1jg.fsf@mail.linkov.net> References: <87h7dl6spg.fsf@gnus.org> <87r1cox4th.fsf@mail.linkov.net> <87h7dkx2g5.fsf@mail.linkov.net> <87r1cm3hqb.fsf@mail.linkov.net> <87h7dgg8go.fsf@mail.linkov.net> <87ilxumi07.fsf@mail.linkov.net> <87sfwvy411.fsf@mail.linkov.net> <86o862re53.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3114"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51173@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 30 10:17:26 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mrzGQ-0000ar-64 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 10:17:26 +0100 Original-Received: from localhost ([::1]:53078 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mrzGO-00032X-9w for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 Nov 2021 04:17:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mrzG2-00031g-Cl for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 04:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56875) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mrzG1-0007a4-To for bug-gnu-emacs@gnu.org; Tue, 30 Nov 2021 04:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mrzG1-00055w-KB; Tue, 30 Nov 2021 04:17:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 30 Nov 2021 09:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51173 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 51173-submit@debbugs.gnu.org id=B51173.163826376819520 (code B ref 51173); Tue, 30 Nov 2021 09:17:01 +0000 Original-Received: (at 51173) by debbugs.gnu.org; 30 Nov 2021 09:16:08 +0000 Original-Received: from localhost ([127.0.0.1]:40188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrzFA-00054m-L3 for submit@debbugs.gnu.org; Tue, 30 Nov 2021 04:16:08 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:43919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mrzF4-00053w-7h for 51173@debbugs.gnu.org; Tue, 30 Nov 2021 04:16:06 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id B81DC240005; Tue, 30 Nov 2021 09:15:54 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 29 Nov 2021 15:57:51 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221105 Archived-At: >> mouse-minibuffer-check(19) >> mouse-set-point(19) >> help--analyze-key("\23" [19] nil) > > Hpw 'bout the patch below? I confirm that the patch fixes this regression, while not breaking other cases. Maybe this patch also obsoletes this code in the same place: ;; Clicks on the menu bar produce "event" that ;; is just '(menu-bar)', for which ;; `mouse-set-point' is not useful. (and (not (windowp (posn-window (event-start event)))) (not (framep (posn-window (event-start event))))) While testing with this code removed, clicks on the menu bar still work without errors. > Or maybe the use of `mouse-minibuffer-check` in `mouse-set-point` should > be moved to its interactive spec? I agree with Eli that more cardinal changes could be tried only in master.