From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51809: 29.0.50; [PATCH] Support for outline default state in Diff buffers Date: Sun, 16 Jan 2022 20:14:15 +0200 Organization: LINKOV.NET Message-ID: <86bl0b35vs.fsf@mail.linkov.net> References: <87lf1sw6ji.fsf@gmail.com> <86h7cgdk4v.fsf@mail.linkov.net> <87ee7kvshn.fsf@gmail.com> <87a6i7x5iq.fsf@gmail.com> <86k0hbam7r.fsf@mail.linkov.net> <878rxrmy7q.fsf@gmail.com> <86y256uc0v.fsf@mail.linkov.net> <87r1ajknsr.fsf@gmail.com> <86ilvu6w6k.fsf@mail.linkov.net> <871r2hc51a.fsf@gmail.com> <87r19zs662.fsf@gmail.com> <871r1zm7ji.fsf@gmail.com> <87wnjrkrwd.fsf@gmail.com> <86ilv8pnf3.fsf@mail.linkov.net> <87k0fouzxs.fsf@gmail.com> <86sftumahu.fsf@mail.linkov.net> <87pmouw9qr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39774"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 51809@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 16 19:15:52 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n9A4E-000A9A-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 19:15:50 +0100 Original-Received: from localhost ([::1]:42776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n9A4D-0005OF-RK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 16 Jan 2022 13:15:49 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n9A3T-0005Cp-Dy for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 13:15:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n9A3T-0006BW-3K for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 13:15:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n9A3S-0006YE-Ug for bug-gnu-emacs@gnu.org; Sun, 16 Jan 2022 13:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jan 2022 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51809-submit@debbugs.gnu.org id=B51809.164235689625114 (code B ref 51809); Sun, 16 Jan 2022 18:15:02 +0000 Original-Received: (at 51809) by debbugs.gnu.org; 16 Jan 2022 18:14:56 +0000 Original-Received: from localhost ([127.0.0.1]:44225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9A3M-0006Wz-E1 for submit@debbugs.gnu.org; Sun, 16 Jan 2022 13:14:56 -0500 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n9A3K-0006Wg-Jq; Sun, 16 Jan 2022 13:14:55 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2CD88FF805; Sun, 16 Jan 2022 18:14:46 +0000 (UTC) In-Reply-To: <87pmouw9qr.fsf@gmail.com> (Matthias Meulien's message of "Fri, 14 Jan 2022 17:41:16 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224408 Archived-At: tags 51809 + patch fixed thanks Hi Matthias, >> # -*- mode: outline-minor; -*- > > This usage of "mode:" looks quite exotic to me. Isn't outine-minor a > minor mode? According to the documentation: > > The special variable/value pair ‘mode: MODENAME;’, if present, > specifies a major mode (without the “-mode” suffix). > > I prefer not support this if possible. You are right, it rather should be more like: -*- mode: text; mode: outline-minor; -*- that is supported. > Here is an updated patch (just rebased my local branch, some minor > conflicts appeared in outline.el): Thanks for working on this patch! I've tested it thoroughly, and everything works nicely, so I pushed it to master. > What would be the next step? Should we stop here or introduce some > customization in Diff mode to help people discover how the "outline > default state feature" can be used there (not convinced myself it'd be > usefull)? Maybe more documentation about using this in diff-mode could be added to the docstrings and to the manual?