From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Mon, 19 Sep 2022 09:42:59 +0300 Organization: LINKOV.NET Message-ID: <86bkrb7qt8.fsf@mail.linkov.net> References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34805"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 57807@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 10:01:46 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBis-0008uf-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 10:01:46 +0200 Original-Received: from localhost ([::1]:54422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaBir-0004UX-Cq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 04:01:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaBbO-0006Zf-Oy for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53120) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaBbO-0004oM-FQ for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaBbO-0007Xe-9r for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 03:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs Original-Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166357402328947 (code B ref 57807); Mon, 19 Sep 2022 07:54:02 +0000 Original-Received: (at 57807) by debbugs.gnu.org; 19 Sep 2022 07:53:43 +0000 Original-Received: from localhost ([127.0.0.1]:52194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBb5-0007Wo-CV for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:53:43 -0400 Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:41835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBb2-0007WU-8r for 57807@debbugs.gnu.org; Mon, 19 Sep 2022 03:53:42 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3E8FA10000B; Mon, 19 Sep 2022 07:53:31 +0000 (UTC) In-Reply-To: <87sfkos6as.fsf@melete.silentflame.com> (Sean Whitton's message of "Sun, 18 Sep 2022 14:48:11 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243039 Archived-At: >> Yes, please try to prepare a patch, preferably without changing the >> established backend API, maybe by using a global variable that later >> could be reused to confirm and edit other commands. > > Here's my attempt. Let me know what you think. Thanks, this would be one of the most useful vc features. I tried it out, and it works nicely. Only minor details: Previously 'git-pull' asked for a full command including command name "git". I know there is no need to edit the command name "git", but splitting the command between the prompt and the minibuffer looks a little odd. Also the previous version of 'vc-git--pushpull' sets 'compile-command' to the edited command. It seems this is implemented to be able to repeat the pull command with 'g' that is bound to 'recompile'. I don't have a good idea how to fix this. Maybe by setting another global variable, e.g. 'vc-last-command' after editing the command in 'vc-do-command'. And also 'vc-do-async-command' reports the initial unedited command with its "Running" message string.