From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#64759: Broken faces Date: Fri, 21 Jul 2023 11:13:13 +0300 Organization: LINKOV.NET Message-ID: <86bkg53cau.fsf@mail.linkov.net> References: <86fs5h4vo2.fsf@mail.linkov.net> <83fs5h1z38.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26068"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 64759@debbugs.gnu.org, Mauro Aranda To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 21 10:24:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qMlRE-0006Xk-JP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jul 2023 10:24:36 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qMlQl-0006mr-JT; Fri, 21 Jul 2023 04:24:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMlQg-0006mK-MM for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 04:24:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qMlQg-0004n5-9J for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 04:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qMlQf-0006qh-T1 for bug-gnu-emacs@gnu.org; Fri, 21 Jul 2023 04:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jul 2023 08:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64759 X-GNU-PR-Package: emacs Original-Received: via spool by 64759-submit@debbugs.gnu.org id=B64759.168992783726314 (code B ref 64759); Fri, 21 Jul 2023 08:24:01 +0000 Original-Received: (at 64759) by debbugs.gnu.org; 21 Jul 2023 08:23:57 +0000 Original-Received: from localhost ([127.0.0.1]:60527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMlQa-0006qM-Qz for submit@debbugs.gnu.org; Fri, 21 Jul 2023 04:23:57 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMlQY-0006q7-6k for 64759@debbugs.gnu.org; Fri, 21 Jul 2023 04:23:54 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id BD388C0005; Fri, 21 Jul 2023 08:23:46 +0000 (UTC) In-Reply-To: <83fs5h1z38.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 21 Jul 2023 10:51:55 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265662 Archived-At: >> This change broke display of `display-time-date-and-time' on the tab-bar: >> >> diff --git a/lisp/time.el b/lisp/time.el >> index 522bec46ac6..0184f96fcc2 100644 >> --- a/lisp/time.el >> +++ b/lisp/time.el >> @@ -141,6 +141,7 @@ display-time-mail-face >> (defface display-time-date-and-time nil >> "Face for `display-time-format'." >> + '((t (:inherit mode-line))) >> :group 'mode-line-faces >> :version "30.1") >> >> This face is used by `tab-bar-format-global' that has nothing to do >> with the mode line, so inheriting from `mode-line' makes no sense. > > ??? It is AFAIU used whenever display-time-mode shows the time when > display-time-day-and-date is non-nil. Where this is shown doesn't > matter, and by default this is shown on the mode line. Thus "makes no > sense" sounds somewhat harsh to me. Sorry, I agree it makes sense when shown on the mode line. > But feel free to change the face definition as you see fit. It seems adding non-empty definitions in bug#64655 were intended to workaround a bug in cus-edit.el, not to fix it. Maybe Mauro could help to fix it (Cc'ed) without requiring non-nil definitions that anyway can not be fixed outside of the Emacs source tree, i.e. in numerous user init files and external packages.