From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#65414: save-some-buffers-functions are unexpectedly called when save-some-buffers pred is non-nil Date: Sun, 03 Sep 2023 20:22:56 +0300 Organization: LINKOV.NET Message-ID: <86bkej18pz.fsf@mail.linkov.net> References: <871qfxvvw9.fsf@breatheoutbreathe.in> <83lee4vcac.fsf@gnu.org> <87o7ixe1e2.fsf@breatheoutbreathe.in> <83o7ixqatx.fsf@gnu.org> <87fs46cn6u.fsf@breatheoutbreathe.in> <838r9ymfh5.fsf@gnu.org> <874jkmck9j.fsf@breatheoutbreathe.in> <83v8ct9gmg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34236"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 65414@debbugs.gnu.org, jonas@bernoul.li, Stefan Monnier , Joseph Turner To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 19:36:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcr1R-0008jm-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 19:36:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcr14-0001ro-0V; Sun, 03 Sep 2023 13:36:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcr12-0001qo-NX for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:36:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcr12-00082Y-FX for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:36:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcr11-0000xU-RX for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 13:36:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 17:36:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65414 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65414-submit@debbugs.gnu.org id=B65414.16937625303612 (code B ref 65414); Sun, 03 Sep 2023 17:36:03 +0000 Original-Received: (at 65414) by debbugs.gnu.org; 3 Sep 2023 17:35:30 +0000 Original-Received: from localhost ([127.0.0.1]:46798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcr0U-0000wC-1m for submit@debbugs.gnu.org; Sun, 03 Sep 2023 13:35:30 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcr0Q-0000vI-Et for 65414@debbugs.gnu.org; Sun, 03 Sep 2023 13:35:26 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 031EFC0007; Sun, 3 Sep 2023 17:35:18 +0000 (UTC) In-Reply-To: <83v8ct9gmg.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Sep 2023 10:30:31 +0300") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269179 Archived-At: >> > In any case, not calling save-some-buffers-functions when PRED is >> > non-nil is not something we can do, as that would be an incompatible >> > behavior change. We could perhaps add PRED to the arguments with >> > which save-some-buffers-functions are called, as an optional argument. >> > Would that be satisfactory? >> >> Yes, that would solve the interference between Magit and hyperdrive.el. >> >> See patch. > > Hmm... but how to make this change backward-compatible? I mean, if > there's some function out there that is used in > save-some-buffers-functions, and it was written to accept only 2 > arguments, we cannot safely call it with 3 arguments, can we? If nothing else helps, just catch 'wrong-number-of-arguments', then call with an obsolete signature again.