From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more Date: Mon, 08 Apr 2024 14:25:02 +0300 Message-ID: <86bk6kyu41.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12266"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70271@debbugs.gnu.org To: Lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 08 13:26:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rtn8g-0002xy-1g for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Apr 2024 13:26:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rtn8U-00054p-1S; Mon, 08 Apr 2024 07:26:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtn8O-00053E-1H for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 07:25:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rtn8N-0005l0-1t for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 07:25:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rtn8U-0002jh-60 for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 07:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Apr 2024 11:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70271-submit@debbugs.gnu.org id=B70271.171257552210337 (code B ref 70271); Mon, 08 Apr 2024 11:26:02 +0000 Original-Received: (at 70271) by debbugs.gnu.org; 8 Apr 2024 11:25:22 +0000 Original-Received: from localhost ([127.0.0.1]:45395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtn7p-0002gT-00 for submit@debbugs.gnu.org; Mon, 08 Apr 2024 07:25:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtn7m-0002fq-Al for 70271@debbugs.gnu.org; Mon, 08 Apr 2024 07:25:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtn7Z-0005bO-5p; Mon, 08 Apr 2024 07:25:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LF3U6BG9qnooZrf0IJ2XLwQZwfV0yE0/qxQhXnhW1fA=; b=QucsjbTAHbfF fd2dlW7L3HlPEujK6ged5nmMH+yGV6RprNVp61krGVrSqnu2tq0SGwlXd3CJMU61/+TwKigMV0Vy/ x8uGW9+Mnt70ZOTxASKLMsSmeuT0y37WapmUvQo+JXFkRhPq9XjocfE1qLPLYV1n+VGoixuTeCq/a 1biNUYhyM2jov0YaWDs5rpJ4xJALAzhAclrzyoC5GlNRu05ShndgtuVXx0Nlub267E+cxmc3jfIcG 155LOIbrUkQAHxSwKpz4VZCiMcAs7n2YFzq4rAJinqejB5Sq7z6bglMks+JTMwI1Cc/nAyUqqdoc/ CUn5fVJsPo08EIvg+IAovQ==; In-Reply-To: (message from Lin Sun on Mon, 8 Apr 2024 05:10:22 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282927 Archived-At: > From: Lin Sun > Date: Mon, 8 Apr 2024 05:10:22 +0000 > > The dired ignored the options like "--time=ctime" in the variable > `dired-listing-switches' on Windows OS. > > I traced the code and found dired will use the functions in the > `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and > the "ls-lisp.el" didn't process the "--time=ctime" option. > > The attached PATCH will convert the "--time=ctime" to "-c"... in the > "ls-lisp.el", and then the dired will display the desired time in its > time column. > > Here is the verification code (on Windows OS), try it one line and > close the dired buffer then try next line. > > (dired "/tmp/aa" "-al --sort=time") ; as "-al -t" > > (dired "/tmp/aa" "-al --time=ctime") ; as "al -c" > > (dired "/tmp/aa" "-al --time=atime") ; as "al -u" > > Please help review the changes and approve them. Thanks Thanks, but how about adding some tests for this?