From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70134: [PATCH] Show all date options when adding Gnus scores interactively Date: Sat, 13 Apr 2024 10:58:37 +0300 Message-ID: <86bk6dr8wi.fsf@gnu.org> References: <87edbovjvj.fsf@kubajecminek.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5408"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70134@debbugs.gnu.org, larsi@gnus.org, alex@bochannek.com To: eric@ericabrahamsen.net, Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 09:59:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvYI0-0001A3-A5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 09:59:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvYHn-0005Ui-9X; Sat, 13 Apr 2024 03:58:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYHl-0005SS-Be for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:58:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvYHl-0006Lh-3Z for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:58:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvYHv-0006ol-9E for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 03:59:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 07:59:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70134 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70134-submit@debbugs.gnu.org id=B70134.171299514126175 (code B ref 70134); Sat, 13 Apr 2024 07:59:03 +0000 Original-Received: (at 70134) by debbugs.gnu.org; 13 Apr 2024 07:59:01 +0000 Original-Received: from localhost ([127.0.0.1]:60045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYHr-0006nt-1R for submit@debbugs.gnu.org; Sat, 13 Apr 2024 03:59:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYHo-0006mW-OB for 70134@debbugs.gnu.org; Sat, 13 Apr 2024 03:58:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYHX-0006ET-C9; Sat, 13 Apr 2024 03:58:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=K8D0R7WPrUGkclXSOchtj9guqLOkr42dE3ICDJ+yxeM=; b=paEKAu/gVnHKfFMFg44K aDO5QG9G+RNovrOO34TGQTvxplpS+zttAwe6IybnEOFPgigoXyvSvWBUWMDiKloOMMmKfAxfMAa99 0P/BnvuXqkH3vNiUtYdd5Y702UF+tS8g6ok350pc/5MHDQ5b+k2/GsuCeemrlmxg2l/yYP13BrLO0 raWl23KETq/VdxwIIeoeA7DI7hP10O8AI3rpXy4aeEz1ToScgBilawWv3onhrLTPGJv1Om7icRBDx N5+kPT+lWhQbp+cnakJTLL6jXSbq1jRsZYI6u9xeDvL9vW/pzcNzO00BFlf0Tc3/ACKJQo5lt+wWA Im9mmSWVZvoOrA==; In-Reply-To: <87edbovjvj.fsf@kubajecminek.cz> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283185 Archived-At: Ping! Eric, any comments? > Cc: Eric Abrahamsen , larsi@gnus.org, > Alex Bochannek > Date: Mon, 01 Apr 2024 21:44:04 +0000 > From: Jakub Ječmínek via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Hello, I'm attaching a patch that enhances user experience when adding > Gnus scores interactively based on date header. This patch does multiple > things: > > 1. `char-to-type' variable is renamed to `char-to-types' and we allow it > to be mapped to multiple types. This is useful because date header > supports all these types for scoring - '<, '>, 'r, 'after, 'before, 'at > but only the last three were previously offered to the user when using > interactive scoring. > > 2. `gnus-summary-score-entry' now provides sensible defaults for each > date scoring type - if we're scoring based on integer value ('<, '>) we > offer number of days between now and entry at point (revised version of > what was introduced in bug#61002) and if we're scoring based on string > value ('after, 'before, 'at, 'r) we provide valid date string. > > 3. If the user scores articles based on date strings ('before, 'after, > 'at, 'r), `gnus-summary-score-entry' will no longer cast the type to the > integer type. > > 4. `gnus-score-date' catches 'r type as well. > > I'm also Cc'ing Alex who was the original author of '< '> date scoring > types. Please let me know what you think.