From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v7] Add support for colored and styled underlines on tty frames Date: Mon, 22 Apr 2024 09:01:28 +0300 Message-ID: <86bk626imf.fsf@gnu.org> References: <87pm7x5mxc.fsf@kisara.moe> <87sezeitkj.fsf@kisara.moe> <87sezegra8.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34594"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mohkale@kisara.moe, 62994@debbugs.gnu.org To: Po Lu , Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 22 08:02:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rymkk-0008mw-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Apr 2024 08:02:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rymkY-000891-Vs; Mon, 22 Apr 2024 02:01:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rymkQ-00084D-2J for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 02:01:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rymkP-0007Y8-Og for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 02:01:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rymke-0008Vr-Qx for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 02:02:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2024 06:02:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171376571532615 (code B ref 62994); Mon, 22 Apr 2024 06:02:04 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 22 Apr 2024 06:01:55 +0000 Original-Received: from localhost ([127.0.0.1]:45510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rymkU-0008Ty-Ak for submit@debbugs.gnu.org; Mon, 22 Apr 2024 02:01:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rymkS-0008Sl-0Y for 62994@debbugs.gnu.org; Mon, 22 Apr 2024 02:01:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rymk6-0007UR-DY; Mon, 22 Apr 2024 02:01:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xlJtvYY7vP+fTx65LZOFb4mcKJ7RZBB5B/oiWt4spL8=; b=U9VCkwso8NOw OOdq1M+b5afbW9UbPmh4MvlGUPcNLTUR8KnP6EFMppsdIC4zt7ST1ABU1FrhFQgSNDu1fwNVbeM+3 qIoXvepyuNNNVdPfGLx4j33eQWSV1gatAaCkOZBkhhJZS79qh73P9z2T3XqBWISpcQf2JR9H9kCRe lrE0P4ZgwnOHoKkTjYLckHsv7ldtUC3A13OhISf8tQn5Dk3DiVAwjx/GzvVVl4VZ91J/aUg6pKXiR Gu12JDg1j1DrC9sNfJHoSdBZQ38A/KxRgu5P+aKZPMKsJZo6xHYaiydEnjPTaJhgV6QdErcQrcT08 sg37o2SN7aTVp4nnnndiqQ==; In-Reply-To: <87sezegra8.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283801 Archived-At: > Cc: 62994@debbugs.gnu.org > Date: Mon, 22 Apr 2024 08:44:15 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > * src/xterm.c (x_draw_glyph_string): Updated to use renamed > > FACE_UNDERLINE_SINGLE and FACE_UNDERLINE_WAVE face_underline_type > > enumerations. > > This change should be accompanied by like updates to *_draw_glyph_string > and related functions in the remaining terminal backends. I believe Jim Porter wanted to work on that. Jim, have you made any progress in this matter? In any case, given that implementing this for GUI displays should not be a problem, I don't see a reason to block this changeset until the GUI parts are done. Hopefully, Jim or someone else will get it ready soon. Thanks.