bug#70587: More buffers that ought to be read-only

bug#70587: More buffers that ought to be read-only

[Dan Jacobson]

diff-default-read-only is a variable defined in ‘diff-mode.el’.
Its value is nil
If non-nil, ‘diff-mode’ buffers default to being read-only.

That's funny, it seems they are already read-only, without setting this
variable. Maybe this variable can be retired.

The *compilation* buffer of M-x compile is also read-only. Good.

But how about *Shell Command Output*, and errors buffers, they should be
read-only by default too.

Why? Because tons of times we realize for the last half hour we have
been editing our program's output buffer instead of the source code.

(Often due to using sh -x or make (without -s) which echo command
lines.)

emacs-version "29.3"

bug#70587: More buffers that ought to be read-only

[Sean Whitton]

Hello,

On Fri 26 Apr 2024 at 09:16am +08, Dan Jacobson wrote:

> diff-default-read-only is a variable defined in ‘diff-mode.el’.
> Its value is nil
> If non-nil, ‘diff-mode’ buffers default to being read-only.
>
> That's funny, it seems they are already read-only, without setting this
> variable. Maybe this variable can be retired.

It's very useful to have them editable sometimes.

> The *compilation* buffer of M-x compile is also read-only. Good.
>
> But how about *Shell Command Output*, and errors buffers, they should be
> read-only by default too.
>
> Why? Because tons of times we realize for the last half hour we have
> been editing our program's output buffer instead of the source code.

No, it is very useful to be able to edit them.

It would make sense to have a customisation variable to change it.

-- 
Sean Whitton

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> From: Dan Jacobson <jidanni@jidanni.org>
> Date: Fri, 26 Apr 2024 09:16:08 +0800
> 
> diff-default-read-only is a variable defined in ‘diff-mode.el’.
> Its value is nil
> If non-nil, ‘diff-mode’ buffers default to being read-only.
> 
> That's funny, it seems they are already read-only, without setting this
> variable. Maybe this variable can be retired.

I cannot reproduce this.  E.g., visiting a file that turned on
diff-mode doesn't make the buffer read-only.  So please show a recipe,
preferably starting from "emacs -Q", where a diff-mode buffer is
read-only without changing this variable from its default value of
nil.

> But how about *Shell Command Output*, and errors buffers, they should be
> read-only by default too.
> 
> Why? Because tons of times we realize for the last half hour we have
> been editing our program's output buffer instead of the source code.
> 
> (Often due to using sh -x or make (without -s) which echo command
> lines.)

A simple "C-x C-q" should set you up, in those cases.

Emacs cannot possibly cater to each and every use case out there.
Sometimes you need to do stuff manually, if your case is specialized
to require that.

bug#70587: More buffers that ought to be read-only

[Dan Jacobson]

All I know is I use
= runs the command dired-diff
Also in the "rare case that one needs to use the washroom while driving the car,"
instead of driving around with the doors open all day long, and seat belts off..."
it should be they who are forced to use C-x C-q to make those buffers read-write.

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> Date: Fri, 26 Apr 2024 19:02:04 +0800
> From: Dan Jacobson <jidanni@jidanni.org>
> Cc: 70587@debbugs.gnu.org
> 
> All I know is I use
> = runs the command dired-diff

In what mode, please?

I asked for a complete reproduction recipe, so could you please
provide such a recipe?

> Also in the "rare case that one needs to use the washroom while driving the car,"
> instead of driving around with the doors open all day long, and seat belts off..."
> it should be they who are forced to use C-x C-q to make those buffers read-write.

Strawman.

bug#70587: More buffers that ought to be read-only

[Dan Jacobson]

EZ> I asked for a complete reproduction recipe, so could you please
EZ> provide such a recipe?

$ emacs -Q /etc
then on e.g., adduser.conf.update-old, press "=", and enter the second
name. Redo shows I did
(dired-diff "/etc/adduser.conf" nil)

Also *Shell Command Output* should be in View mode.
Otherwise every time we expect to scroll it,
the strangest thing happens. We end up inserting a
space (' ') into the beginning of the first line.
And, a half an hour later, having forgot that mishap,
end up sticking a "q" in it when it's time to leave.
q as in quicksand, which is what the buffer feels like.

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> From: Dan Jacobson <jidanni@jidanni.org>
> Cc: 70587@debbugs.gnu.org
> Date: Sat, 27 Apr 2024 15:24:52 +0800
> 
> EZ> I asked for a complete reproduction recipe, so could you please
> EZ> provide such a recipe?
> 
> $ emacs -Q /etc
> then on e.g., adduser.conf.update-old, press "=", and enter the second
> name. Redo shows I did
> (dired-diff "/etc/adduser.conf" nil)

Thanks.  This is because the command 'diff' unconditionally puts the
buffer into read-only mode.

Stefan, this seems to be due to your changes in b2e4481906ec: you
added '(setq buffer-read-only t)' which was not there before (in fact,
the code before those changes did the opposite:

--- a/lisp/vc/diff.el
+++ b/lisp/vc/diff.el
@@ -131,37 +147,32 @@
-        (thisdir default-directory)
-        proc)
-    (save-excursion
-      (display-buffer buf)
-      (set-buffer buf)
-      (setq buffer-read-only nil)
+    (with-current-buffer buf
+      (setq buffer-read-only t)

So I suggest to remove the setting of buffer-read-only there'
diff-mode will do TRT according to diff-default-read-only.

> Also *Shell Command Output* should be in View mode.
> Otherwise every time we expect to scroll it,
> the strangest thing happens. We end up inserting a
> space (' ') into the beginning of the first line.
> And, a half an hour later, having forgot that mishap,
> end up sticking a "q" in it when it's time to leave.
> q as in quicksand, which is what the buffer feels like.

That's a separate issue, and I don't agree that *Shell Command Output*
should be in View mode by default.  The space will only be inserted if
you mistakenly think the buffer is in View mode, and likewise with
'q'.

bug#70602: Add hooks to control *Shell Command Output*

[Dan Jacobson]

M-! (translated from <escape> !) runs the command shell-command (found
in global-map), which is an interactive native-compiled Lisp function
in ‘simple.el’.

There are no hooks available to make the buffer it creates be in View Mode.

One cannot even, via .emacs, make it read-only.

bug#70587: More buffers that ought to be read-only

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Stefan, this seems to be due to your changes in b2e4481906ec: you
> added '(setq buffer-read-only t)' which was not there before (in fact,
> the code before those changes did the opposite:
>
> --- a/lisp/vc/diff.el
> +++ b/lisp/vc/diff.el
> @@ -131,37 +147,32 @@
> -        (thisdir default-directory)
> -        proc)
> -    (save-excursion
> -      (display-buffer buf)
> -      (set-buffer buf)
> -      (setq buffer-read-only nil)
> +    (with-current-buffer buf
> +      (setq buffer-read-only t)
>
> So I suggest to remove the setting of buffer-read-only there'
> diff-mode will do TRT according to diff-default-read-only.

There is no right or wrong answer here.  The current design reflects the
behavior I think makes more sense, but that's largely just my
personal preference.  The above patch was no mistake.

But if we install the above patch, then *vc-diff* will suddenly not be
read-only any more, so we should arguably change
`diff-default-read-only` at the same time, which will in turn cause
another behavior change when people open a `.diff` file.


        Stefan

bug#70587: More buffers that ought to be read-only

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> There is no right or wrong answer here.  The current design reflects the
> behavior I think makes more sense, but that's largely just my
> personal preference.  The above patch was no mistake.
>
> But if we install the above patch, then *vc-diff* will suddenly not be
            ^^^^^^^
            revert


- Stefan

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Dan Jacobson <jidanni@jidanni.org>,  70587@debbugs.gnu.org
> Date: Sat, 27 Apr 2024 23:02:16 -0400
> 
> > Stefan, this seems to be due to your changes in b2e4481906ec: you
> > added '(setq buffer-read-only t)' which was not there before (in fact,
> > the code before those changes did the opposite:
> >
> > --- a/lisp/vc/diff.el
> > +++ b/lisp/vc/diff.el
> > @@ -131,37 +147,32 @@
> > -        (thisdir default-directory)
> > -        proc)
> > -    (save-excursion
> > -      (display-buffer buf)
> > -      (set-buffer buf)
> > -      (setq buffer-read-only nil)
> > +    (with-current-buffer buf
> > +      (setq buffer-read-only t)
> >
> > So I suggest to remove the setting of buffer-read-only there'
> > diff-mode will do TRT according to diff-default-read-only.
> 
> There is no right or wrong answer here.  The current design reflects the
> behavior I think makes more sense, but that's largely just my
> personal preference.  The above patch was no mistake.

If your personal preference is that diff-mode buffers should be
read-only, then you (and those who agree with you) should customize
diff-default-read-only to a non-nil value.  What we have now is a
mess: some cases which invoke diff-mode behave according to
diff-default-read-only, while others behave differently
unconditionally.

However, if by "no mistake" you mean something else, please elaborate
why it was no mistake.

> But if we install the above patch, then *vc-diff* will suddenly not be
> read-only any more, so we should arguably change
> `diff-default-read-only` at the same time, which will in turn cause
> another behavior change when people open a `.diff` file.

Why should *vc-diff* be read-only regardless of
diff-default-read-only?  And why visiting a .diff file is different in
this regard?

bug#70587: More buffers that ought to be read-only

[Dan Jacobson]

I got an idea: how about a pair of variables

"buffers-that-should-be-read-only-regexp",
"buffers-that-should-not-be-read-only-regexp",

which would be shipped with reasonable defaults...

And then the user can tweak them to their own tastes.

bug#70587: More buffers that ought to be read-only

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Why should *vc-diff* be read-only regardless of
> diff-default-read-only?  And why visiting a .diff file is different in
> this regard?

I've been wondering the same and I don't have a good answer.
In practice, I edit diffs much more often when they're in a file than when
they're in *vc-diff*, but it's far from clear to me why that is the case.


        Stefan

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: jidanni@jidanni.org,  70587@debbugs.gnu.org
> Date: Sun, 28 Apr 2024 10:57:26 -0400
> 
> > Why should *vc-diff* be read-only regardless of
> > diff-default-read-only?  And why visiting a .diff file is different in
> > this regard?
> 
> I've been wondering the same and I don't have a good answer.
> In practice, I edit diffs much more often when they're in a file than when
> they're in *vc-diff*, but it's far from clear to me why that is the case.

Does it mean you will not be terribly mad if I remove the read-only
setting from "M-x diff", and let it behave as every other client of
diff-mode?

bug#70587: More buffers that ought to be read-only

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Does it mean you will not be terribly mad if I remove the read-only
> setting from "M-x diff", and let it behave as every other client of
> diff-mode?

I don't have a strong opinion on this, no (diff-mode buffers are
among those where I use `C-x C-q` most frequently).

`C-x v =` is an important "client of diff-mode" (arguably more
important than `M-x diff`), and it does make `*vc-diff*` read-only,
so if you want to change `M-x diff`, I suggest you change `C-x v =` at
the same time.


        Stefan

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: jidanni@jidanni.org,  70587@debbugs.gnu.org
> Date: Sun, 28 Apr 2024 11:30:26 -0400
> 
> > Does it mean you will not be terribly mad if I remove the read-only
> > setting from "M-x diff", and let it behave as every other client of
> > diff-mode?
> 
> I don't have a strong opinion on this, no (diff-mode buffers are
> among those where I use `C-x C-q` most frequently).
> 
> `C-x v =` is an important "client of diff-mode" (arguably more
> important than `M-x diff`), and it does make `*vc-diff*` read-only,
> so if you want to change `M-x diff`, I suggest you change `C-x v =` at
> the same time.

So the two most important clients of diff-mode unconditionally make
the buffer read-only, but we have a diff-mode option that by default
leaves the buffer writable?  This makes absolutely no sense to me!

Does anyone have any explanation for how we ended up in this
situation?

bug#70587: More buffers that ought to be read-only

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

> Does anyone have any explanation for how we ended up in this
> situation?

I view the read-only or not status as something that depends more on
where the data came from than on the mode being used for it.

[ So, by and large, I agree with Dan that things like `*Shell Command
  Output*` and errors buffers might benefit from being made read0only by
  default.  ]


        Stefan

bug#70587: More buffers that ought to be read-only

[Dan Jacobson]

On Sat, May 04, 2024 at 10:36:07AM -0400, Stefan Monnier wrote:
> [ So, by and large, I agree with Dan that things like `*Shell Command
>   Output*` and errors buffers might benefit from being made read0only by
>   default.  ]

Currently there is no way for users to even make *Shell Command
Output* read only even if they wanted. No hook. No variable. Nothing.

Execpt of course manually hitting C-x C-q. Good thing at least one can also set view-read-only.

Also what's so good about having *Shell Command Output* read-write,
when anything you change will get lost? Unless OK, you are planning to
feed it back in to a second shell-command-on-region.

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> Date: Sun, 5 May 2024 05:40:03 +0800
> From: Dan Jacobson <jidanni@jidanni.org>
> Cc: Eli Zaretskii <eliz@gnu.org>, Dmitry Gutov <dmitry@gutov.dev>,
> 	70587@debbugs.gnu.org
> 
> On Sat, May 04, 2024 at 10:36:07AM -0400, Stefan Monnier wrote:
> > [ So, by and large, I agree with Dan that things like `*Shell Command
> >   Output*` and errors buffers might benefit from being made read0only by
> >   default.  ]
> 
> Currently there is no way for users to even make *Shell Command
> Output* read only even if they wanted. No hook. No variable. Nothing.
>
> Execpt of course manually hitting C-x C-q. Good thing at least one can also set view-read-only.

I'm okay with adding a hook, patches welcome.

> Also what's so good about having *Shell Command Output* read-write,
> when anything you change will get lost? Unless OK, you are planning to
> feed it back in to a second shell-command-on-region.

I'm sorry, but this kind of reasoning is a non-starter.  That you
personally (and a couple of others) would prefer those buffers to be
read-only is not a reason good enough to make the change affect
everyone else, given that the current behavior is very old.  Not going
to happen.

bug#70587: More buffers that ought to be read-only

[Dmitry Gutov]

On 28/04/2024 08:13, Eli Zaretskii wrote:
>> But if we install the above patch, then*vc-diff*  will suddenly not be
>> read-only any more, so we should arguably change
>> `diff-default-read-only` at the same time, which will in turn cause
>> another behavior change when people open a `.diff` file.
> Why should*vc-diff*  be read-only regardless of
> diff-default-read-only?  And why visiting a .diff file is different in
> this regard?

I also think that we should flip diff-default-read-only to true, and 
drop the special casing in vc-diff. :-)

bug#70587: More buffers that ought to be read-only

[Eli Zaretskii]

> Date: Sun, 28 Apr 2024 23:35:34 +0300
> Cc: 70587@debbugs.gnu.org, jidanni@jidanni.org
> From: Dmitry Gutov <dmitry@gutov.dev>
> 
> On 28/04/2024 08:13, Eli Zaretskii wrote:
> >> But if we install the above patch, then*vc-diff*  will suddenly not be
> >> read-only any more, so we should arguably change
> >> `diff-default-read-only` at the same time, which will in turn cause
> >> another behavior change when people open a `.diff` file.
> > Why should*vc-diff*  be read-only regardless of
> > diff-default-read-only?  And why visiting a .diff file is different in
> > this regard?
> 
> I also think that we should flip diff-default-read-only to true, and 
> drop the special casing in vc-diff. :-)

That doesn't answer my questions.

Flipping the default value would require much more than 2 or 3 people
asking for it.

bug#70587: More buffers that ought to be read-only

[Dan Jacobson]

[-- Attachment #1: Type: text/html, Size: 864 bytes --]