From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: James Thomas via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71720: [PATCH] Do not prematurely truncate python eldoc string Date: Sun, 23 Jun 2024 08:32:19 +0530 Message-ID: <86bk3s9xac.fsf@gmx.net> References: <86frt5xi3e.fsf@outlook.com> <86jzihgmet.fsf@gnu.org> <86ed8pgenb.fsf@gnu.org> <86msncvg0r.fsf@gmx.net> Reply-To: James Thomas Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22336"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 71720@debbugs.gnu.org To: kobarity Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 23 05:03:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sLDVm-0005dW-8v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jun 2024 05:03:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sLDVQ-0003bv-K0; Sat, 22 Jun 2024 23:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sLDVP-0003be-04 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 23:03:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sLDVO-0004Fm-OR for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 23:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sLDVO-0001nN-I2 for bug-gnu-emacs@gnu.org; Sat, 22 Jun 2024 23:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: James Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2024 03:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71720-submit@debbugs.gnu.org id=B71720.17191117606862 (code B ref 71720); Sun, 23 Jun 2024 03:03:02 +0000 Original-Received: (at 71720) by debbugs.gnu.org; 23 Jun 2024 03:02:40 +0000 Original-Received: from localhost ([127.0.0.1]:41323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLDV2-0001mc-0C for submit@debbugs.gnu.org; Sat, 22 Jun 2024 23:02:40 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:52925) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sLDV0-0001mM-1R for 71720@debbugs.gnu.org; Sat, 22 Jun 2024 23:02:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1719111748; x=1719716548; i=jimjoe@gmx.net; bh=FTFNQufGJiLdwETlX1LUNGb5XEGKl+UKdNkc0jMi36Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=IxLGft3S8eU9/u0HYzu/BeTaN/RTulD2nab7mydl9ycdXR4s5yalf1iJPbRH84i5 jzh1VrQCyaZdt8/Jyp+JIQWNOIFp99Flmxy3GB2BZ5/MD6QL+7RkWnbVmXQrX04ox Sl3rEktJbg7DMrXg3VobXg6VaRwFdidIbNlh6tP5Eu+JcxW5i6+2leeRq242SOoMt /9Z2EkMYeIy5xY4WHJ6XtVF8SFv5hxTfwNcZmjQAwEnjI2qXnLQWuDWhsii9wXs32 2B7LKRtyBm1hGDXnv0sdcahEV+uu/t5tk/XYUWTMqz2shOBB22hMNzXvDyeoGeTpS 0kd5JVUN1woe4CS+vw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from user-Inspiron-3493 ([117.242.203.20]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MSKyI-1rx8713SCe-00Mcra; Sun, 23 Jun 2024 05:02:28 +0200 In-Reply-To: (kobarity@gmail.com's message of "Sun, 23 Jun 2024 09:47:58 +0900") X-Provags-ID: V03:K1:OflyxVS6KleoCafiTZHLRe1QpQ8upjQOB2hpT3Ea493EjbecmvF PZ5AV0pGA1rNHgpbH6zfe3XCrxOQy1TTBSXs1CB6GkvJS7uoc0ouxI5zHQ0hyXKp2cdnNtX 7rAi0H0B3gHqyvnm1uXTpevXKiy/IdQQQOalqhWEFCEwVDsRWj0q09Ua45MCFqNwU8I/bbJ drYzUGmMdNWT0F4GGM/zQ== UI-OutboundReport: notjunk:1;M01:P0:zM6ilTJOm6Q=;A6KsAZ89o8ltAaONtDYpl0R+OdB NTuUg10tJ31RiZTf89iG1n65znBI0SNtV23KlwgW2fQeoohFwr9fL7AwAD54kiANlpmqPAxTN fhFcxbVLCPL9I1HVuIJeueOjHfI0tTnUyMG/RwwVOrcl8c/CAWk6hNJesUZ4V7/mbBDpH31KV eHFRB9lNa14+o1PA+oIJcxvknjZr89rNHPW2QTYzWM8HJNOSFmLAHSF5iTUAzJBtE2m6VpzR/ YdWl8jA5DufHFSr8Z2hl4KzXApxbdvcepNs7aptk5m5eb6xG74jgaO27OudiiffzIQbVmSpF/ /gla+ag6KV424rpK+Yw9YmovPnFfVrqQd3iQZAPaPbHWfcpLOzhtttZ2Q7MAvVi2CxEZ601Mo QODwZY+pMCG8w7q36SfQRruoQ+WnIY8MZp5LmSOnKKG+scN0RUrT1JlNWnAwsLkSR/02PPknZ Bu/1Pk7w+nFedSFMcJJbKf1UwoyRS5wlp1W74TJRS6bBBSqAYE6TZrqOMJXgb3SSU3kENZr0L HrSJepSObZJBXaqFtn0KDFEUvK+T0Mixqft/DHsO0VFmAtZYjhCKdfkdbD1OAxmayrXR+Sozo Py+mvXDpXIKmXersVLQ2v4kdAyPeWR4OWWYT1YfKpU1PyyuxXWRuwYy1IKCm9slvib4aNhOgt 1AC1QaJVfIvm7tPNlnpiaJFoLB0XAy5FGpv96dLE/Yyt5vt16tumG750ozelryIh/xAAr1XqI T8P14dfsBfjBDaDjHcbBgaQ0G03k9Ko2q3/QJVzIfk4QkGk/o70oBQpMaGgkrdvMg/usCsCQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287752 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable kobarity wrote: > James Thomas wrote: >> Eli Zaretskii wrote: >> >> >> Date: Sat, 22 Jun 2024 23:16:51 +0900 >> >> From: kobarity >> >> Cc: 71720@debbugs.gnu.org >> >> >> >> Eli Zaretskii wrote: >> >> > >> >> > kobarity, any comments? >> >> >> >> I agree with this fix. For those who want the same behavior as >> >> before, setting eldoc-echo-area-use-multiline-p to nil should be >> >> sufficient. It might be better to make this change known in etc/NEW= S, >> >> though. >> > >> > Thanks. >> > >> > James, can you add a NEWS entry and resubmit? >> >> How about this? > >> +*** 'eldoc' no longer truncates to a single line by default. >> +Previously, the entire docstring was not available to eldoc, which mad= e >> +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may b= e >> +kept by setting that. >> + > > Thanks, I think the content is perfect, but from other examples, it > might be better to have two spaces after the period. Fixed: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Do-not-prematurely-truncate-python-eldoc-string.patch Content-Description: [PATCH] Do not prematurely truncate python eldoc string Content-Transfer-Encoding: quoted-printable =46rom f91a94aca5119ebde21e24392b0d46d44dd9e078 Mon Sep 17 00:00:00 2001 From: James Thomas Date: Sat, 22 Jun 2024 17:57:00 +0530 Subject: [PATCH] Do not prematurely truncate python eldoc string 'eldoc-echo-area-use-multiline-p' is there for that. * lisp/progmodes/python.el (python-eldoc-setup-code): Make the change. =2D-- etc/NEWS | 5 +++++ lisp/progmodes/python.el | 2 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 2349cc0cacb..201ef46bac5 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -1499,6 +1499,11 @@ interactive Python interpreter specified by 'python= -interpreter'. It sends the python block delimited by 'python-nav-beginning-of-block' and 'python-nav-end-of-block' to the inferior Python process. +*** 'eldoc' no longer truncates to a single line by default. +Previously, the entire docstring was not available to eldoc, which made +'eldoc-echo-area-use-multiline-p' ineffective. The old behaviour may be +kept by setting that. + ** Inferior Python mode --- diff --git a/lisp/progmodes/python.el b/lisp/progmodes/python.el index bb2bf1731b4..a52e21f625e 100644 =2D-- a/lisp/progmodes/python.el +++ b/lisp/progmodes/python.el @@ -5607,8 +5607,6 @@ python-eldoc-setup-code doc =3D '{objtype} {name}{args}'.format( objtype=3Dobjtype, name=3Dname, args=3Dargs ) - else: - doc =3D doc.splitlines()[0] except: doc =3D '' return doc" =2D- 2.43.0 --=-=-= Content-Type: text/plain -- --=-=-=--