From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71655: Eshell external commands do not work under GNU Emacs for Windows Date: Mon, 08 Jul 2024 14:09:39 +0300 Message-ID: <86bk3816oc.fsf@gnu.org> References: <86y170oifx.fsf@gnu.org> <86v824ohym.fsf@gnu.org> <86r0csnrk7.fsf@gnu.org> <8b97b729-c431-1dc2-d4d4-b988120e7de0@gmail.com> <86cyocnjkl.fsf@gnu.org> <858d2907-7ee4-da6f-cd9e-6b7bd3ba4c7e@gmail.com> <86pls8ff73.fsf@gnu.org> <875xtyyjcv.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20577"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael.albinus@gmx.de, 71655-done@debbugs.gnu.org, james@literate-devops.io To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 08 13:10:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQmG2-0004zH-LV for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jul 2024 13:10:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQmFr-0002cP-Ot; Mon, 08 Jul 2024 07:09:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQmFq-0002c8-Cf for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 07:09:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQmFq-0001gb-2Y for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 07:09:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQmFt-0005pf-Rf for bug-gnu-emacs@gnu.org; Mon, 08 Jul 2024 07:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jul 2024 11:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71655 X-GNU-PR-Package: emacs Original-Received: via spool by 71655-done@debbugs.gnu.org id=D71655.172043699622398 (code D ref 71655); Mon, 08 Jul 2024 11:10:01 +0000 Original-Received: (at 71655-done) by debbugs.gnu.org; 8 Jul 2024 11:09:56 +0000 Original-Received: from localhost ([127.0.0.1]:49809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQmFn-0005pB-Kh for submit@debbugs.gnu.org; Mon, 08 Jul 2024 07:09:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQmFl-0005ou-JZ for 71655-done@debbugs.gnu.org; Mon, 08 Jul 2024 07:09:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQmFa-0001em-U2; Mon, 08 Jul 2024 07:09:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iG3B3AEWW2rc1ydVA+q2hYvFSPGt6Z1v/hQ/24BvjBA=; b=OIAN90tncDE7 1ukoYbKJgdBz8DGOxjcMInwwQmBBqxBBKyqlf/X4tc5IdnRmKZd0LAMcqbtYqjY0bZINBhjowJGrd n8vjiR1O+oNUxAdnkffcFvMfdLoUEMpFTwwURrMhPtkcy48a6hmA0rKWhzVk+s8f4mUUgQ04bGOIm igEANP9IB6mDbMoVbgSN5XiZF4RhpHwzAHnr+7GyPNX7boLGSvej2WmdUKgDtdlIQ+m/GBaZP4XIq JgmfSX9Oh//jlYrp+ypiDRJE/ks39LQfbc1q+TKY5WBbjTKX/6VSK0mGJ8i3hnfNHxgoakbEi0nzv //L2selFY+E9WoA9zzdE2Q==; In-Reply-To: (message from Jim Porter on Sun, 7 Jul 2024 20:26:17 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288585 Archived-At: > Date: Sun, 7 Jul 2024 20:26:17 -0700 > Cc: Eli Zaretskii , 71655-done@debbugs.gnu.org, > james@literate-devops.io > From: Jim Porter > > On 6/23/2024 10:56 PM, Michael Albinus via Bug reports for GNU Emacs, > the Swiss army knife of text editors wrote: > > Jim Porter writes: > > > >> I'll think about this some more and see if we can get all the checks > >> we want without making the code slower over Tramp. (Maybe Tramp caches > >> enough that this isn't a problem, but I'm not certain yet.) > > > > If Eshell calls `process-file', it shall bind `process-file-side-effects' > > to nil if appropriate for the given command. > > > > Furthermore, Eshell might bind `remote-file-name-inhibit-cache' to > > something which helps. The default value (10) seems to be very conservative. > After looking into this, it turns out Eshell doesn't look for a shebang > on remote files (a comment in 'eshell-connection-local-command' claims > that it doesn't work with Tramp syntax, but I'm not sure that's actually > correct...). > > I've therefore merged the "B" variant of my patch to emacs-30 (as commit > 130c3efa108) that checks for zero size on the file. I thought about it > and this way seemed safer, since I'm not sure what other scenarios might > signal a 'file-error', and I'd rather not suppress something I > shouldn't: better for a user to file another bug in that case so we can > evaluate it, I think. > > Closing this bug now. (Though of course let me know if I've missed > anything here.) Thanks, this is fine by me.