From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72426: 29.2.50; comint-pager doesn't affect async-shell-command Date: Sat, 03 Aug 2024 18:38:56 +0300 Message-ID: <86bk29vcof.fsf@gnu.org> References: <86sevmupgo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6954"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72426@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 03 17:40:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saGrZ-0001fL-S2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 03 Aug 2024 17:40:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saGrB-0008Qe-6Q; Sat, 03 Aug 2024 11:39:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saGr9-0008QG-6O for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 11:39:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saGr8-0001tD-SO for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 11:39:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=Y+Wmbkyc5z7Dldkh5A2c7rU3V/PEKF7xanqeIXSLqww=; b=I+L2HZfUQoBtb6KsfL5ZJFpjc9M78DzswMWKw94F72Q9vXC72j+z6UU4j6KM7/Mshkuk6s0+HiajcFzIxAhcH9mkkyYu03tZxnzlRONCFs/JC4aBJVR+cOYUB8qiJMLkvjueSXpcL5rmHtdqPPTK+xvoEkCtCQp69+FLrLp6oEDiQX5Rz9+iFuOMPbBVMsszKJzoLjAgL8ydVZSgEZSXaE9lAbT/bxmiPggHjaBuUMMVDR5ppk9v3hizZJwpK+gcwxCwokjpJrxraGATbYmf8YSsAa8EhV9YfJgT/m/bHIJowG4JdFLYebIMt3aOiIG1lwk3jAqUMotdRR9wMPif4A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saGrS-0008W2-Kq for bug-gnu-emacs@gnu.org; Sat, 03 Aug 2024 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 03 Aug 2024 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72426 X-GNU-PR-Package: emacs Original-Received: via spool by 72426-submit@debbugs.gnu.org id=B72426.172269956832669 (code B ref 72426); Sat, 03 Aug 2024 15:40:02 +0000 Original-Received: (at 72426) by debbugs.gnu.org; 3 Aug 2024 15:39:28 +0000 Original-Received: from localhost ([127.0.0.1]:54697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saGqu-0008Ur-G8 for submit@debbugs.gnu.org; Sat, 03 Aug 2024 11:39:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saGqs-0008Ud-3s for 72426@debbugs.gnu.org; Sat, 03 Aug 2024 11:39:27 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saGqR-0001qG-3y; Sat, 03 Aug 2024 11:38:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Y+Wmbkyc5z7Dldkh5A2c7rU3V/PEKF7xanqeIXSLqww=; b=FBB8JPVFr4G39MLQ4wIU 6sYDt4iQ26VmbkoCUMw6H0kcvXAK/6g3mh3qh5+7yI67yviu1IkAR1N1kYxpGIHg+s0CIFySG5hip BZg1fe210MW6gT98/+FoVAvhTqtC0X7O/8PypRsbWXojb4Yjats/k36ZYNyR9gDoVadmn0LGNxwM2 29uwcINvz9e2IfkQHgAcWsJmjUCtBKUcnmjFIc49cSKgvEMwC++AweciPO5t7kwkKMdryEiDPr7q6 8cOiAuiuYI8VSjuN4mWVtxVcgBApq/bZiD30ZvmSsYbYRYbPoGmADn1hmQavQS1sireFuhqB5YRdz QO3g5XdHYUxUXQ==; In-Reply-To: (message from Spencer Baugh on Sat, 3 Aug 2024 06:47:10 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289681 Archived-At: > From: Spencer Baugh > Date: Sat, 3 Aug 2024 06:47:10 -0400 > Cc: 72426@debbugs.gnu.org > > On Sat, Aug 3, 2024, 1:48 AM Eli Zaretskii wrote: > > > From: Spencer Baugh > > Date: Fri, 02 Aug 2024 14:35:25 -0400 > > > > > > 1. PAGER=less emacs -Q > > 2. (setq comint-pager "cat") > > 3. (async-shell-command "echo $PAGER") > > 4. Observe "less" rather than "cat". > > > > I intended async-shell-command to also be affected when I added > > comint-pager; a patch to fix this will follow. > > Thanks, I don't think this is right: comint stuff should not affect > lower-level primitives, it should only affect comint and its callers. > > comint-terminfo-terminal affects async-shell-command, why not this? Ugh! A mistake, IMNSHO. But that ship sailed a long time ago, so we cannot fix the mistake. We can avoid enlarging the mistake, though. > If the fact that the variable is in comint is the problem, I can rename it and move it elsewhere. I don't think functions that are almost primitives should pay attention to application-level features such as this one. > Lisp programs that use async-shell-command can arrange for > process-environment to have PAGER=SOMETHING as they see fit. > > My intention is primarily to affect interactive usage of async-shell-command. But comint-term-environment also affects "M-x compile".