unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: spacibba@aol.com, maurooaranda@gmail.com
Cc: 72156@debbugs.gnu.org, Stephen Berman <stephen.berman@gmx.net>
Subject: bug#72156: 31.0.50; defcustom set issue
Date: Sun, 04 Aug 2024 10:38:42 +0300	[thread overview]
Message-ID: <86bk28u48t.fsf@gnu.org> (raw)
In-Reply-To: <86le1we9aw.fsf@gnu.org> (message from Eli Zaretskii on Sat, 20 Jul 2024 11:50:47 +0300)

merge 72156 72404
thanks

> Cc: 72156@debbugs.gnu.org
> Date: Sat, 20 Jul 2024 11:50:47 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Date: Wed, 17 Jul 2024 14:08:59 +0200
> > From:  Ergus via "Bug reports for GNU Emacs,
> >  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> > 
> > I have this defcustom:
> > 
> > ```
> > (defcustom gtags-mode-features '(control meta)
> >   "HELLO WORLD"
> >   :type '(set (const control)
> >               (const meta)
> >               (const shift)
> >               (const hyper)
> >               (const super)
> >               (const alt)))
> > ```
> > 
> > When I try the customize-variable I get this:
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [X] control
> > [X] meta
> > [ ] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > But, if I do the next change and save
> > 
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [X] control
> > [X] meta
> > [X] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > The customize variable value saved is:
> > 
> > '(gtags-mode-features3 '(shift))
> > 
> > it only saved the "new" value and ignores the previous
> > existing ones.
> > 
> > When I restart and check the variable's value I get as expected '(shift)
> > and lost the control and meta.
> > 
> > Going to customize-variable again I get:
> > 
> > ```
> > Hide Gtags Mode Features:
> > Set:
> > [ ] control
> > [ ] meta
> > [X] shift
> > [ ] hyper
> > [ ] super
> > [ ] alt
> >    [ State ]: EDITED, shown value does not take effect until you set or save it.
> >    HELLO WORLD
> > Groups: [Gtags Mode]
> > ```
> > 
> > Consistent with the variable value, but inconsistent with what was
> > actually saved before.
> > 
> > IF instead of selecting a new value I un-select some, then variable
> > saves nil and will be nil.
> 
> This seems to be some bug in handling the 'set' type of defcustoms.  I
> see the same problem when customizing completions-merging-modes from
> completion.el.  Perhaps Mauro (CC'ed) could chime in and suggest how
> to solve this.

This actually seems to be the same problem as bug#72404, since the fix
proposed by Stephen there fixes this one as well.  So I'm merging them.





      reply	other threads:[~2024-08-04  7:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87le206x0k.fsf.ref@aol.com>
2024-07-17 12:08 ` bug#72156: 31.0.50; defcustom set issue Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-20  8:50   ` Eli Zaretskii
2024-08-04  7:38     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bk28u48t.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=72156@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    --cc=spacibba@aol.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).