From: Eli Zaretskii <eliz@gnu.org>
To: "Björn Bidar" <bjorn.bidar@thaodan.de>
Cc: 72526@debbugs.gnu.org
Subject: bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port
Date: Sat, 17 Aug 2024 09:02:19 +0300 [thread overview]
Message-ID: <86bk1r661g.fsf@gnu.org> (raw)
In-Reply-To: <87bk1stevo.fsf@> (bug-gnu-emacs@gnu.org)
> Date: Fri, 16 Aug 2024 23:02:51 +0300
> From: Björn Bidar via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Could someone please review my patch?
Sorry, I don't see any experts around to ask to do that.
Maybe if you'd posted a more detailed description of the problem and
its context, someone could follow your arguments and do a meaningful
review. E.g., it sounds from your description like the case of URLs
where it currently fails was not meant to be supported by this
library? If so, perhaps an alternative is to submit to this library
only URLs that it supports, like after stripping the port part?
On another level: please make sure you leave 2 spaces between
sentences in comments, strings, and commit log messages. And I don't
think the 3rd patch belongs to this issue, so let's not include it in
this discussion.
Thanks.
next parent reply other threads:[~2024-08-17 6:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87bk1stevo.fsf@>
2024-08-17 6:02 ` Eli Zaretskii [this message]
2024-08-17 8:41 ` bug#72526: 31.0.50; [PATCH] Fix url-basic-auth secret search when passing username and/or port Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <877ccftubm.fsf@>
2024-08-17 10:49 ` Eli Zaretskii
2024-08-17 20:50 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87zfpaswk4.fsf@>
2024-08-18 5:15 ` Eli Zaretskii
2024-08-18 12:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87v7zyrp29.fsf@>
2024-08-18 13:13 ` Eli Zaretskii
2024-08-19 6:54 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87zfp9q9ym.fsf@>
2024-08-24 8:59 ` Eli Zaretskii
2024-08-24 11:59 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87y14mb07y.fsf@>
2024-08-24 12:51 ` Eli Zaretskii
2024-08-26 6:05 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87h6b7byzb.fsf@>
2024-08-26 11:14 ` Eli Zaretskii
[not found] <87r0azawml.fsf@>
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-16 20:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-08 14:59 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bk1r661g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72526@debbugs.gnu.org \
--cc=bjorn.bidar@thaodan.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).