From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72966: 30.0.90; [PATCH] php-ts-mode: custom php.ini config for the built-in php webserver Date: Mon, 02 Sep 2024 17:23:53 +0300 Message-ID: <86bk16877q.fsf@gnu.org> References: <5614567.rdbgypaU67@fedora> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72966@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 02 16:25:52 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sl804-0004NB-Sh for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Sep 2024 16:25:49 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sl7zP-0000AR-VM; Mon, 02 Sep 2024 10:25:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl7zM-00008z-T6 for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 10:25:05 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sl7zJ-0004wm-3a for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 10:25:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=OQdVTAMfG6mS96gf15U9lLolbJEsaALY5FCZdD8jaJY=; b=sFL7EahEPVhYI3+6n9/QHAbznBwhrUL6dIy3p0opaxf+fe6UD2cldbJuA7BbMrDBO/rgG0CUBVihgKTXXAi6ybgJNpRYJLhqbhk4QxxK9AiuinZ0B7pSUc8okgmiEtcCnoq5Srp2j1T5joJfV4zpE12iU1aHa5jdEiPBCwvC+pWOfVL1HWW/zo19x/9QT4S4g/M89ZWf+PJAR4V58UWIy7OfhV0ReyaoCVRo3ljF8tvtjomQL/bAeI3hAUCeNoYPUHio2++4q7c2lBijPUzvvgUprlmHPQW22dO7LIrLVfqQ95+nNCKoydCq9xbIRPyz6wuJnUj1/p1bwKqvH0xrAw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sl80H-0007Rf-W0 for bug-gnu-emacs@gnu.org; Mon, 02 Sep 2024 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Sep 2024 14:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72966 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72966-submit@debbugs.gnu.org id=B72966.172528713028533 (code B ref 72966); Mon, 02 Sep 2024 14:26:01 +0000 Original-Received: (at 72966) by debbugs.gnu.org; 2 Sep 2024 14:25:30 +0000 Original-Received: from localhost ([127.0.0.1]:49839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sl7zm-0007Q9-4c for submit@debbugs.gnu.org; Mon, 02 Sep 2024 10:25:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sl7zk-0007Pv-9U for 72966@debbugs.gnu.org; Mon, 02 Sep 2024 10:25:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sl7yf-0004v3-RF; Mon, 02 Sep 2024 10:24:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OQdVTAMfG6mS96gf15U9lLolbJEsaALY5FCZdD8jaJY=; b=eEeym14eDI2u Mezgqdpc2XAjYJxZpDh8/VAsMjBVsZN7erUmTHgwQkaF0oFGRQ0VM5lzZghEGzFDEyuvfnk78sD1m QXRZPdN3nZqQEMyyxlnCH0m6Vt+IXHOfJY7LfrXHvivQEpQ+7EDiarphjfyq4TzvWuzM2GNQeofhY WOfbUJeLocOVnv1T0cB0kLAaDWgdVoDvvSee/dCAL8oje0NgGMQSMiWzlnvI4hQFxeha/KKIWtYa6 gY47dGTr1I5BIi23pQhxXLxLem3iZ3+xC8q5VCaV7gUU8RB4dRqNAt78Pdv1Vlpq57gAG1D5sDqEN 9VOj/Lcn8ozNwKSUgP+gtg==; In-Reply-To: <5614567.rdbgypaU67@fedora> (message from Vincenzo Pupillo on Mon, 02 Sep 2024 15:29:23 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291108 Archived-At: > From: Vincenzo Pupillo > Date: Mon, 02 Sep 2024 15:29:23 +0200 > > Ciao, > this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver' that > allows you to specify an alternative php.ini file to the default (or whatever > is specified in 'php-ts-mode-php-config'). Thanks. > -(defun php-ts-mode-run-php-webserver (&optional port hostname document-root > - router-script num-of-workers) > +(defun php-ts-mode-run-php-webserver (&optional port > + hostname > + document-root > + router-script > + config > + num-of-workers) > "Run PHP built-in web server. This changes a public API in backward-incompatible way, something we don't do, because it could break someone's code out there. (It is true that php-ts-mode was introduced in Emacs 30, but that version is already in pretest and will be released soon, so I don't think we can change this there, either.) So please find a backward-compatible way of adding this feature, perhaps add the new CONFIG argument as the last one? Also, I think this needs a NEWS entry describing the change in behavior.