From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74902: 31.0.50; Segfault when deleting frames Date: Fri, 10 Jan 2025 14:44:13 +0200 Message-ID: <86bjwe2602.fsf@gnu.org> References: <87frmoy5aq.fsf@stebalien.com> <861py7r5jq.fsf@gnu.org> <87v7vjk3nl.fsf@stebalien.com> <87frmn5yu5.fsf@gmail.com> <865xn4t4z6.fsf@gnu.org> <87v7v3bden.fsf@stebalien.com> <86ldvzq8xa.fsf@gnu.org> <877c7fg6gn.fsf@stebalien.com> <874j2bj6wr.fsf@gmail.com> <87bjweq58l.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24972"; mail-complaints-to="usenet@ciao.gmane.io" Cc: steven@stebalien.com, 74902@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 10 13:45:41 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tWEOT-0006Ka-G3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Jan 2025 13:45:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tWEO1-0007aU-PP; Fri, 10 Jan 2025 07:45:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWENt-0007Yv-IK for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2025 07:45:08 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tWENr-0008AK-NC for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2025 07:45:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=3qesjoDpkzGwP46Z0lHvSA6ySxXLIGD9DAXILwXkdEw=; b=IZ4C84mBozqK5G8G1mWxPsAS40tm1zJVMU57kM91mH5UCDixnTa6uv1DPvMDARyzH1fhATlcdL/iomi5O3ixMnZ9wvpIODSTwn/q9sggmdGFTRrEqCGc+DylJCR1IvGJ1FzkrLhN3Y3uhH/y8T1bCjk37hgmA6qUzs/YTAzFq+8y4ZHpfWzuCJpyN6Rdowc/SZ7u/ND/3JaI2mAv0IhGJdLHcCMATwrNhJQUhG+PWyxkmfp8NdKFjpekoFJZ5s/NeiabHabVwSKcjrfpAfNKJpv/+WDP3VJ5yfupETiPFT2grWtsIqNKDegL24iR+xqsHmJr2w7AEaS69E7mDrX1Fg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tWENq-0007sb-HV for bug-gnu-emacs@gnu.org; Fri, 10 Jan 2025 07:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jan 2025 12:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74902 X-GNU-PR-Package: emacs Original-Received: via spool by 74902-submit@debbugs.gnu.org id=B74902.173651306830200 (code B ref 74902); Fri, 10 Jan 2025 12:45:02 +0000 Original-Received: (at 74902) by debbugs.gnu.org; 10 Jan 2025 12:44:28 +0000 Original-Received: from localhost ([127.0.0.1]:56627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tWENI-0007r2-85 for submit@debbugs.gnu.org; Fri, 10 Jan 2025 07:44:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33656) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tWENF-0007qk-Ec for 74902@debbugs.gnu.org; Fri, 10 Jan 2025 07:44:26 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tWEN8-00087r-Vo; Fri, 10 Jan 2025 07:44:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3qesjoDpkzGwP46Z0lHvSA6ySxXLIGD9DAXILwXkdEw=; b=UU9dibU7efvA jyX255IW0Roaksyx8YGB0rusApvrHraW9/aCNyW9YrTC7ZYT9EQ2LlRO3nFfjtGIn5cDI3fC5d3w5 MlrlzD/Q2HuUG9CW5b5c4V0HtIjh/4/f8Q34B2SFZK4NQUsQ05yKtA5lOIUQQKZ9hlXtxIhqsG/jn qXDI9vDsuIYiVxEd4mADkUU8QlQSzGJYAg36eIMoXh6ejp9QzqVXRMLLZ6Tv/N0/REJHJHo4cjXGe R8IqibsH8p04s+CkZZvQIJPlJKYZgif7ly6FaWWnEiDRS7jHytjDq2nqLpo9Qw8rdBFDVDvtp7F/R 0bAb+lcbVB2Wzs5UGDDk/w==; In-Reply-To: <87bjweq58l.fsf@gmail.com> (message from Robert Pluim on Fri, 10 Jan 2025 12:26:50 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298879 Archived-At: > From: Robert Pluim > Cc: Steven Allen , 74902@debbugs.gnu.org > Date: Fri, 10 Jan 2025 12:26:50 +0100 > > >>>>> On Tue, 07 Jan 2025 10:43:32 +0100, Robert Pluim said: > > >>>>> On Tue, 31 Dec 2024 08:31:04 -0800, Steven Allen said: > Steven> Eli Zaretskii writes: > >>> Thanks. I guess we also need a FRAME_LIVE_P test in > >>> gui_consider_frame_title? > > Steven> I've attached a patch for that but note that it doesn't actually help in > Steven> this situation because the frame isn't deleted until: > > Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2536 > > Steven> Whereas the crash happens here, 36 lines above: > > Steven> https://git.savannah.gnu.org/cgit/emacs.git/tree/src/frame.c?h=2f1052d9b0de551dc3a463ed54e21c63517497ab#n2500 > > Robert> gui_consider_frame_title looks at Vframe_list, so removing the > Robert> to-be-deleted frame from it should be enough (unless this crash was > Robert> with my patch applied?) > > Eli, did you still want me to push the change to master? Yes, why not? I don't really understand the last 2 exchanges.