From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 52491@debbugs.gnu.org
Subject: bug#52491: 28.0.90; Regression in window deletion with minibuffer
Date: Tue, 21 Dec 2021 10:05:52 +0200 [thread overview]
Message-ID: <86a6gucrhb.fsf@mail.linkov.net> (raw)
In-Reply-To: <1cba0ff2-3345-d2f4-f9a3-a61c79487a50@gmx.at> (martin rudalics's message of "Mon, 20 Dec 2021 19:08:40 +0100")
>> Do you think this is safe enough to install on the release branch?
>
> Probably not. I'm confused as to which posts made it today to the list.
> A correct patch is attached now and should be safe for Emacs 28.
>
> @@ -5167,7 +5167,10 @@ quit-restore-window
> (cond
> ;; First try to delete dedicated windows that are not side windows.
> ((and dedicated (not (eq dedicated 'side))
> - (window--delete window 'dedicated (eq bury-or-kill 'kill))))
> + (window--delete window 'dedicated (eq bury-or-kill 'kill))
> + (or (and (window-live-p (nth 2 quit-restore))
> + (select-window (nth 2 quit-restore)))
> + t)))
Or maybe simply:
((and dedicated (not (eq dedicated 'side))
(window--delete window 'dedicated (eq bury-or-kill 'kill)))
;; If the previously selected window is still alive, select it.
(when (window-live-p (nth 2 quit-restore))
(select-window (nth 2 quit-restore))))
next prev parent reply other threads:[~2021-12-21 8:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 21:08 bug#52491: 28.0.90; Regression in window deletion with minibuffer Juri Linkov
2021-12-16 17:28 ` Juri Linkov
2021-12-16 17:50 ` Eli Zaretskii
2021-12-16 19:02 ` Juri Linkov
2021-12-16 20:05 ` Eli Zaretskii
2021-12-17 8:25 ` Juri Linkov
2021-12-17 12:04 ` Eli Zaretskii
2021-12-18 9:05 ` martin rudalics
2021-12-18 17:20 ` Juri Linkov
2021-12-19 10:14 ` martin rudalics
2021-12-19 17:14 ` Juri Linkov
2021-12-19 18:16 ` martin rudalics
2021-12-19 18:25 ` Juri Linkov
2021-12-20 9:18 ` martin rudalics
2021-12-20 17:29 ` Eli Zaretskii
2021-12-20 18:08 ` martin rudalics
2021-12-20 18:18 ` Eli Zaretskii
2021-12-21 8:05 ` Juri Linkov [this message]
2021-12-21 10:33 ` martin rudalics
2021-12-21 19:13 ` Juri Linkov
2021-12-22 9:23 ` martin rudalics
2021-12-21 8:08 ` Juri Linkov
2021-12-21 10:34 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a6gucrhb.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=52491@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).