unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55743@debbugs.gnu.org
Subject: bug#55743: 28.1.50; No directory error in comp-run-async-workers
Date: Wed, 01 Jun 2022 22:13:37 +0300	[thread overview]
Message-ID: <86a6aw2o4e.fsf@mail.linkov.net> (raw)
In-Reply-To: <83h754hbwf.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 01 Jun 2022 14:16:16 +0300")

>> >> Shouldn't native compilation run in the directory where the emacs
>> >> source files are located instead of running in the default directory
>> >> of an arbitrary buffer that might be invalid?
>> >
>> > No, because native compilation could be invoked to compile a file that
>> > has nothing to do with the Emacs source tree, e.g., some file of the
>> > user or some 3rd-party package installed in some arbitrary place.
>> 
>> Still, shouldn't it run compilation in the same directory
>> where that file is located?  Isn't this better than running
>> compilation in a random dir from a random buffer?
>
> No, it isn't better, because the directory should be set by the
> caller.  The compilation primitive cannot second-guess what the caller
> meant.  For example, the file to be compiled could load other files,
> and load-path could mention the current directory in some relative
> form; or the directory of the file could not be chdir'ed into, but
> files in it could be accessed; or some VCS could be involved (so you
> need to be in the VCS repository), or something else.  make-process
> uses the default-directory of the current buffer because making sure
> that directory is the correct one is left to the caller, and it makes
> it easy for the caller to ensure the compilation runs in the correct
> directory.

I don't understand who is the caller?  The user?  The user visits
an non-existent directory, by e.g. `C-x C-f /bla/bla/bla', then
emacs compilation kicks in using that directory, and signals the error.
If this is the intended behavior, then I guess this bug report can be closed,
since I fixed the non-existent directory case in *Completions*.





  reply	other threads:[~2022-06-01 19:13 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31 17:31 bug#55743: 28.1.50; No directory error in comp-run-async-workers Juri Linkov
2022-05-31 19:07 ` Eli Zaretskii
2022-05-31 19:49   ` Juri Linkov
2022-06-01  2:33     ` Eli Zaretskii
2022-06-01  6:13       ` Juri Linkov
2022-06-01 11:16         ` Eli Zaretskii
2022-06-01 19:13           ` Juri Linkov [this message]
2022-06-01 19:49             ` Eli Zaretskii
2022-06-02  7:40               ` Juri Linkov
2022-06-02  8:02                 ` Eli Zaretskii
2022-06-02  8:17                   ` Lars Ingebrigtsen
2022-06-02  8:44                     ` Eli Zaretskii
2022-06-02  8:51                       ` Lars Ingebrigtsen
2022-06-02 10:48                         ` Eli Zaretskii
2022-06-03  3:10                           ` Lars Ingebrigtsen
2022-06-03  5:55                             ` Eli Zaretskii
2022-06-03  8:22                               ` Andreas Schwab
2022-06-03 11:43                                 ` Eli Zaretskii
2022-06-02  8:17                   ` Andreas Schwab
2022-06-02  8:45                     ` Eli Zaretskii
2022-06-02 17:30                       ` Juri Linkov
2022-06-02 19:02                         ` Eli Zaretskii
2022-06-03  7:49                           ` Juri Linkov
2022-06-03 11:12                             ` Eli Zaretskii
2022-06-01  6:10     ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a6aw2o4e.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=55743@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).