unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Randy Taylor <dev@rjt.dev>
Cc: noah.v.peart@gmail.com, casouri@gmail.com, 70362@debbugs.gnu.org,
	dmitry@gutov.dev
Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode
Date: Thu, 18 Apr 2024 17:15:22 +0300	[thread overview]
Message-ID: <86a5lqeozp.fsf@gnu.org> (raw)
In-Reply-To: <N32PMs79gKrndJdQYBCnV1oOjg_h1Pw56m1vKaVfY5GM-SvuY-8ldoRMuLgP3JvdqjPS6uDX3HzGM2078vxkBeOxQ_dC_yA0bfHOV_WXdSM=@rjt.dev> (message from Randy Taylor on Thu, 18 Apr 2024 13:44:56 +0000)

> Date: Thu, 18 Apr 2024 13:44:56 +0000
> From: Randy Taylor <dev@rjt.dev>
> Cc: noah.v.peart@gmail.com, casouri@gmail.com, dmitry@gutov.dev, 70362@debbugs.gnu.org
> 
> On Thursday, April 18th, 2024 at 06:32, Eli Zaretskii <eliz@gnu.org> wrote:
> > 
> > > Date: Tue, 16 Apr 2024 00:44:16 +0000
> > 
> > > From: Randy Taylor dev@rjt.dev
> > > Cc: Yuan Fu casouri@gmail.com, Dmitry Gutov dmitry@gutov.dev, Eli Zaretskii eliz@gnu.org, 70362@debbugs.gnu.org
> > > 
> > > Thanks for working on this Noah, it looks good to me as well.
> > > 
> > > Perhaps builtin could come before constant in treesit-font-lock-feature-list to keep things alphabetical?
> > 
> > 
> > I've rearranged them, thanks for noticing this.
> 
> Thanks, but I was referring to the treesit-font-lock-feature-list variable (see attached patch), not go-ts-mode--font-lock-settings which is not alphabetized.

Thanks, installed.





  reply	other threads:[~2024-04-18 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-13  5:47 bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Noah Peart
2024-04-13  7:23 ` Eli Zaretskii
2024-04-13  7:40   ` Noah Peart
2024-04-13 12:16     ` Dmitry Gutov
2024-04-14 23:32 ` Yuan Fu
2024-04-16  0:44   ` Randy Taylor
2024-04-18 10:32     ` Eli Zaretskii
2024-04-18 13:44       ` Randy Taylor
2024-04-18 14:15         ` Eli Zaretskii [this message]
2024-04-18 10:31   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a5lqeozp.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70362@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=dmitry@gutov.dev \
    --cc=noah.v.peart@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).