From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72404: 30.0.60; Customization of options is broken Date: Sun, 04 Aug 2024 10:49:52 +0300 Message-ID: <86a5hsu3q7.fsf@gnu.org> References: <86a5hxv6cp.fsf@mail.linkov.net> <86frrpxws9.fsf@gnu.org> <87le1hs1s2.fsf@pub.pink> <867cd0ygkf.fsf@gnu.org> <878qxga6vv.fsf@gmx.net> <87ttg48863.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72404@debbugs.gnu.org, jm@pub.pink, maurooaranda@gmail.com, juri@linkov.net To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 09:51:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saW1F-0003Ec-36 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 09:51:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saW0v-0004aV-K0; Sun, 04 Aug 2024 03:50:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saW0o-0004ZJ-A5 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:50:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saW0n-00025z-V2 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:50:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=z/shrS+nvt+FgDvW8fmWCibibnAYu1w/Cr55ENwKga8=; b=kG7opwdk8gMcxY6dPce+JKQlKX09JP4k9u25WetrCaXgwysSf6TbODrCHHJYzxA0ktPRBjZLfe3AV1aEyP2K3rrd3h2DyAN2VDCQwkHuioeSHH9W9Qyff7tfbN3qQiJhBmiwll4OrIn0KaxFumVNhsPTeHVm8iEHU05DIfRy3sB9GINjC9mDZQnQkqj9gNqulYH5FumKi1dTbeZyVws3ro63RO944PlpGZTKllDElA5nSvlXR8J3mIAKjRA5dZU4X8tj/8bQGkoNMidNKVVXr5FYZHemYUgIgGzdEDcqtApgNJSgKSzsNV3m/uDzzeMYqBWCz/8PtApCBffM8bXp+Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saW18-0004j3-FD for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 03:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 07:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72404 X-GNU-PR-Package: emacs Original-Received: via spool by 72404-submit@debbugs.gnu.org id=B72404.172275782518055 (code B ref 72404); Sun, 04 Aug 2024 07:51:02 +0000 Original-Received: (at 72404) by debbugs.gnu.org; 4 Aug 2024 07:50:25 +0000 Original-Received: from localhost ([127.0.0.1]:55354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saW0X-0004h8-DF for submit@debbugs.gnu.org; Sun, 04 Aug 2024 03:50:25 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saW0U-0004gk-GM for 72404@debbugs.gnu.org; Sun, 04 Aug 2024 03:50:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saW02-0001Uh-5V; Sun, 04 Aug 2024 03:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z/shrS+nvt+FgDvW8fmWCibibnAYu1w/Cr55ENwKga8=; b=j9QId17bnuOD LAm3mP55K9SZy8n2bV2FsWD/Lq4JXKhPgqjBTyAA454BhYIrcsi/s00pZ7hmts7DfvkOv/GY8QJvk 85o0OKjfYvTZzSvfzeg6IaxnKz2Seb4v+RoVwXIPHTOtCbiAa642ARRLYCJdwf8BlPZWn0Ba3NRY5 ZTst3Xuy0wOW2Eb3um6Xpcygskq4AZ+voPPcZpNG73IQPLRjGNJ+Bq4GWa+4uY6Edro5H7yLk15di JeIfBh9bcVq5vgWKwm61c06Z0Dblx2g3sZHN3iBYNNzaYp+5Z/ZfAOG/eBmC4pVTPO9PrfqEply5g NMPxQyxBLRYhpjW2XVUkOQ==; In-Reply-To: <87ttg48863.fsf@gmx.net> (message from Stephen Berman on Thu, 01 Aug 2024 19:28:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289713 Archived-At: > From: Stephen Berman > Cc: john muhl , juri@linkov.net, maurooaranda@gmail.com, > 72404@debbugs.gnu.org > Date: Thu, 01 Aug 2024 19:28:04 +0200 > > On Thu, 01 Aug 2024 12:12:52 +0200 Stephen Berman wrote: > > I did happen to have a bit more time for this problem, and I think I've > found the cause, a single line in commit 8d354925ddb: > > diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el > index 693991a6f3e..aa653549dad 100644 > --- a/lisp/wid-edit.el > +++ b/lisp/wid-edit.el > @@ -2549,7 +2549,8 @@ widget-checklist-add-item > (t > (widget-create-child-value > widget type (car (cdr chosen))) > - (widget-specify-selected child))))) > + ;; (widget-specify-selected child) > + )))) > (t > (error "Unknown escape `%c'" escape))))) > ;; Update properties. > > With this line commented out as in the above patch, I get the expected > value when carrying out Juri's recipe. Moreover, after making that > change, I then briefly tested customizing the face widget-unselected > (which the problematic commit added) to inherit from the default face > and it shows the labels of unselected check boxes in the default face, > as it should. So maybe deleting the commented out line above and > leaving the rest of the change is a sufficient fix. But I have to admit > I don't know why that line causes the problem, and I haven't done enough > testing of this change to the widget-unselected face feature, so this is > just a status report. Thanks, I installed the above fix. It turns out the same problem also caused bug#72156, so I've now merged them. I'm leaving this bug open, in the hope that you or someone else will find the root cause for the regression and fix it.