From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73779: 30.0.91; [PATCH] php-ts-mode: Better indentation and font locking, support for the latest grammar version. Date: Sun, 13 Oct 2024 07:59:23 +0300 Message-ID: <86a5f8vbro.fsf@gnu.org> References: <2520493.XAFRqVoOGU@fedora> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27493"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73779@debbugs.gnu.org To: Vincenzo Pupillo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 13 07:00:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1szqi8-0006zj-NC for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Oct 2024 07:00:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szqhp-0005En-OM; Sun, 13 Oct 2024 00:59:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szqho-0005Ef-DF for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 00:59:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szqho-0000hy-3q for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 00:59:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=8NXOqlZrJTUWVspzu7QCXCeCBfH9WiF10HVWMedLqiA=; b=fr5TpDj6g1OiWbNKEDBym2KhwU6k/1aSYvBBGAvTXIb1oq1kD25kq3X0Pk3uMQdSmr/K8IxADSLi84KG5q7Yuj8UmPQUgLmFkYcDKTDMJZjaSeXKmGTScxqarhPDmF5cJwh8mcSNMrmGMeBTH7vPaHK4dbwm/R4AxtJ/eax4UnwkHR8ZTOUVarZZq64xMas5K8ER0lz3rK9TvNyuQDMvr6TYIlOKuj3IAvpu4oXkkoTG3OtqDCQkbNIZbYPfaT5laEUjCHNMdfkz6i08Ww4QXfatXg0XEiSZGimUqiwJRwo7MRLrmg53mq3u08A0D2HvRr6D+EqjHB9KrMM/9aLspw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szqi2-0007fE-Lp for bug-gnu-emacs@gnu.org; Sun, 13 Oct 2024 01:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Oct 2024 05:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73779 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73779-submit@debbugs.gnu.org id=B73779.172879559129413 (code B ref 73779); Sun, 13 Oct 2024 05:00:02 +0000 Original-Received: (at 73779) by debbugs.gnu.org; 13 Oct 2024 04:59:51 +0000 Original-Received: from localhost ([127.0.0.1]:49870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szqhr-0007eK-8t for submit@debbugs.gnu.org; Sun, 13 Oct 2024 00:59:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szqhp-0007e3-1o for 73779@debbugs.gnu.org; Sun, 13 Oct 2024 00:59:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szqhU-0000hG-BI; Sun, 13 Oct 2024 00:59:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8NXOqlZrJTUWVspzu7QCXCeCBfH9WiF10HVWMedLqiA=; b=nYwwgu/yL6cMuGQlI8Fw 0xXb9Zns7YORM4cP20bOkws4lO88by2C9zALuJig4z0546vSiOjPOD6Uaty8/WhiPE3N/sl+ckOtI vYczo6vgknCKnaROtV5btB+KJbUuszG+3hWek07BbRm4692HMXkQBXLMehc6DVs3xNcNySTtrazGt GOTDPO9SnMiDaPtt3hclv2UKT9V/AceIAKRZPrw2rrq8sX3KJqF/x4O/Zjrl8dHby1UVGDi8joDiG y7VhdeUxG1tIIVyCP2PkYLsl7bYSf48zpiDVu2RJLT6yIgTrKRagtTvns6julPAbSMgoyknAnxBiU m4b4Rj9+jDQR8A==; In-Reply-To: <2520493.XAFRqVoOGU@fedora> (message from Vincenzo Pupillo on Sat, 12 Oct 2024 22:12:30 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293491 Archived-At: > From: Vincenzo Pupillo > Date: Sat, 12 Oct 2024 22:12:30 +0200 > > this patch corrects the indentation of the control structure without closing > brackets (or without the end keyword... in the case of the alternative > syntax). It supports font locking of the “asymmetric property visibility ” > introduced with grammar v0.23.3 and so-called magic methods. And others small > fix. And others small bug I discovered while writing the tests.. Thank you. I have two questions about this: . will the code which uses the "asymmetric property visibility" also work without problems with versions of the grammar library before 0.23.3? . do you consider the code changes to be tested well enough and thus safe to be installed on the emacs-30 release branch? I'd prefer to install on emacs-30, because this mode is new in Emacs 30, unless you are not sure the code is safe enough.