From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>,
Stefan Monnier <monnier@iro.umontreal.ca>,
Stefan Kangas <stefankangas@gmail.com>,
Andrea Corallo <acorallo@gnu.org>
Cc: 74019@debbugs.gnu.org, juri@linkov.net
Subject: bug#74019: [PATCH] Optionally preserve selected candidate across *Completions* update
Date: Sat, 26 Oct 2024 09:45:14 +0300 [thread overview]
Message-ID: <86a5erbbwl.fsf@gnu.org> (raw)
In-Reply-To: <ier1q03x409.fsf@janestreet.com> (bug-gnu-emacs@gnu.org)
> Cc: Juri Linkov <juri@linkov.net>
> Date: Fri, 25 Oct 2024 17:32:38 -0400
> From: Spencer Baugh via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Add completion-preserve-selection, a defcustom which allows keeping the
> same selected candidate after *Completions* is updated by
> minibuffer-completion-help.
Shouldn't we stop complicating the completion machinery at some point?
It is already basically impenetrable, and if someone still can reason
about what it does in any specific case, my hat's off to them; I have
long ago reached the point where the _only_ way of understanding
what's going on is to step with a debugger through the code -- and it
doesn't help that some of the code is in Lisp and some in C, so Lisp
calls into C, which calls back into Lisp, etc., thus one needs to
interrupt the stepping, fire up a different debugger, then go back.
Stefan, WDYT? Should we close completion to further development and
accept only bugfixes?
What do Stefan Kangas and Andrea think?
> +(defcustom completion-preserve-selection nil
> + "If non-nil, `minibuffer-completion-help' preserves the selected completion candidate.
This doc-string line is too long.
I also don't like the name: "selection" could be confused to mean the
X selection. I'd use "selected-candidates" instead.
> +If non-nil, and point is on a completion candidate in the displayed
> +*Completions* window, `minibuffer-completion-help' will put point on the
> +same candidate after updating *Completions*."
This is completely unclear: what does minibuffer-completion-help have
to do with updating *Completions*?
> + (current-candidate-and-offset
> + (when-let* ((window (get-buffer-window "*Completions*" 0)))
> + (with-selected-window window
> + (when-let* ((beg (completions--start-of-candidate-at (point))))
> +
> + (cons (get-text-property beg 'completion--string) (- (point) beg))))))
Why is this done unconditionally? with-selected-window is not a cheap
function.
> @@ -4905,8 +4928,6 @@ minibuffer-next-completion
> (interactive "p")
> (let ((auto-choose minibuffer-completion-auto-choose))
> (with-minibuffer-completions-window
> - (when completions-highlight-face
> - (setq-local cursor-face-highlight-nonselected-window t))
Why is this being moved to a different place?
next prev parent reply other threads:[~2024-10-26 6:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 21:32 bug#74019: [PATCH] Optionally preserve selected candidate across *Completions* update Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-26 6:45 ` Eli Zaretskii [this message]
2024-10-26 14:59 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-28 14:08 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-27 7:55 ` Juri Linkov
2024-10-28 13:57 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-26 14:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-28 13:51 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-28 14:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-28 16:01 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-29 2:53 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-29 16:25 ` Spencer Baugh via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-29 18:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5erbbwl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=74019@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@janestreet.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).