From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#73862: [PATCH] Add `header-line-active` and `header-line-inactive` faces. Date: Sun, 27 Oct 2024 12:46:53 +0200 Message-ID: <86a5epakma.fsf@gnu.org> References: <87y12lo9hb.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29375"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73862@debbugs.gnu.org To: trevor.m.murphy@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 27 11:48:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t50om-0007Qk-GU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Oct 2024 11:48:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t50ny-0006JO-6h; Sun, 27 Oct 2024 06:47:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t50nw-0006J5-3k for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 06:47:28 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t50nv-0006S1-Ql for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 06:47:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=BB35g0hzpztjHqAwte7y6nEZXyiiBO3OR/36mhwCD30=; b=OcnLQxggpT433IACmhoh/8tfk39VdGahKGifECRstxHqBt4nBL3tz89pOQvXf7XEJReN0Dq2LDmPUaofBzg2rgHpCS0mYb6zRtDBfOm3IaDoDDld+6ldMDIzqsv4+z0Yq4W21zOsbNCov2x5Srp4omqXsAFOD69cK071Jp7CAx8/RC2grMFAXucCrxMZiWj0qjqZZITzakYPSBshVW1gZbyPIjG1XSlQbVM90YoAbr32WIeIo/9PyWzDTbwFOZqZSnlPYgj+z+3noqRpxdGk8/vUj953RjjNpRG8Df1W+Q4RSRCk+AnR3/XkWAmHcL5yOhK7Wu3QdJKq5jrV/Q5upg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t50oU-00079O-Bs for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 06:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2024 10:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73862 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73862-submit@debbugs.gnu.org id=B73862.173002605927442 (code B ref 73862); Sun, 27 Oct 2024 10:48:02 +0000 Original-Received: (at 73862) by debbugs.gnu.org; 27 Oct 2024 10:47:39 +0000 Original-Received: from localhost ([127.0.0.1]:44003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t50o6-00078X-RM for submit@debbugs.gnu.org; Sun, 27 Oct 2024 06:47:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47666) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t50o5-00078K-C2 for 73862@debbugs.gnu.org; Sun, 27 Oct 2024 06:47:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t50nR-0006QO-An; Sun, 27 Oct 2024 06:46:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BB35g0hzpztjHqAwte7y6nEZXyiiBO3OR/36mhwCD30=; b=ZqJGON0NiPPv Zf3rkPzTBOCypq2RiiSYqXiiqEp/Y63+F/uPpDVIbQT2bvZZI/w0R0pKGo5Yz5/sJrzaOdHBZMSZF Ahf2k8+Q9jCdMMhWZQ1wNO8Xnr0ACTNGaTvNH26Rd2MU5fqxIZKSYVsLXyAacxVqd5IXGT4icvXlE SO2yzFo2BPRCXRztInFclO4ycrQW7jJZ8DrhnQUsFjYc6yD+x1SdtajPYVOWRLz/e0p3Y5P/71Ze5 JwWOU+QXn5SxpZaZMDUOZY40o+v2RW53Jbqxh3xhGDsAiU3LiFCCcwq+OUiliTTiOtkKq8lUWI3Qn UzvDLRm0OTuLOSucflit1g==; In-Reply-To: <87y12lo9hb.fsf@gmail.com> (trevor.m.murphy@gmail.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294333 Archived-At: > From: trevor.m.murphy@gmail.com > Date: Fri, 18 Oct 2024 05:56:32 -0700 > > Over the years I've put more and more information into the header line, and at some point I wanted to get that quick visual indicator of selected vs non-selected windows when I glanced at the header as I already got from the mode line. > > This was surprisingly hard to achieve! For a few years I used an ugly `buffer-list-update-hook` hack. Then a few months ago I got adventurous and found that it actually wasn't as hard as I'd feared to hack these into the C source. > > The new faces both inherit from the current `header-line` face, so there shouldn't be any visible impact if users don't customize the new faces. For cases like mine it's easy to customize header-line-inactive to inherit from mode-line-inactive. > > Thanks in advance for your attention and feedback, Thanks. This changeset needs the appropriate changes in the Emacs user manual (which lists the standard faces in "Standard Faces"), and also a NEWS entry that announces the change. Also, did you verify that modes which use header-line and customize the header-line face still work as before after this change, both when the window is selected and non-selected?