From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#13692: mouse clicks in vc-dir buffers accidentally changing marks Date: Sat, 30 Jan 2021 16:05:05 +0200 Message-ID: <86a50315-e3c4-1a6f-a92e-abcca84b81b3@yandex.ru> References: <875z3suun0.fsf@gnus.org> <87o8hijql0.fsf@gnus.org> <927a3c2e-bd77-df54-303c-e9c098f5d244@yandex.ru> <875z3nv5lq.fsf@gnus.org> <47d355fe-e472-dc0d-fead-a1450849afc6@yandex.ru> <875z3ko9e8.fsf@gnus.org> <1a3779a7-bb20-39c9-45d8-71c7e6d973ab@yandex.ru> <87wnvzf9a1.fsf@gnus.org> <396e50bb-c4a2-b5d5-068d-54b1921f7fc0@yandex.ru> <87o8h70wsx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34841"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Glenn Morris , 13692@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 30 15:06:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l5qt9-0008xb-6D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jan 2021 15:06:11 +0100 Original-Received: from localhost ([::1]:52754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l5qt7-00029K-Rv for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Jan 2021 09:06:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l5qt0-00029A-Au for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 09:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l5qt0-0003Gs-3Z for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 09:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l5qsz-0006j4-UG for bug-gnu-emacs@gnu.org; Sat, 30 Jan 2021 09:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Jan 2021 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13692 X-GNU-PR-Package: emacs Original-Received: via spool by 13692-submit@debbugs.gnu.org id=B13692.161201551725796 (code B ref 13692); Sat, 30 Jan 2021 14:06:01 +0000 Original-Received: (at 13692) by debbugs.gnu.org; 30 Jan 2021 14:05:17 +0000 Original-Received: from localhost ([127.0.0.1]:54168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5qsH-0006i0-CR for submit@debbugs.gnu.org; Sat, 30 Jan 2021 09:05:17 -0500 Original-Received: from mail-wm1-f54.google.com ([209.85.128.54]:38457) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l5qsF-0006hl-PC for 13692@debbugs.gnu.org; Sat, 30 Jan 2021 09:05:16 -0500 Original-Received: by mail-wm1-f54.google.com with SMTP id y187so9365097wmd.3 for <13692@debbugs.gnu.org>; Sat, 30 Jan 2021 06:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ZI64sRvYc9W7xCpmdc3uKNOEr6J3WDocze9wc0h2ZmM=; b=APJ94x6PmLOZVfl9WcvjP9bLkITCp5sHOV0Ot1lr6wE/ILzXP3VB3aWuQCqC6Kb/1e WDd7Vwp1s6/Mai4AcWNOmKadHaVRem/pmPlB0HceTEpHG5UED54Fe4RLVQ1vvg1BW/pN hbntTipmPfJDrw3r4dm/lOz0uxXeFnvEPDlExUZHoyVojWTS67uncRkKlxcjABXa4er6 6RLqO72n979Noxk73oGhlPn14ShhGPmAP633PMdtH9bladbrxRGkQpKK2kGqhhNWesDI 7/rdyOFAFPWH5iqwNv7hcnXT8F/rwA0Qxa0SYTNeNOWyTGglhoUBUsD9tuEZJ3pUWvcG lUHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ZI64sRvYc9W7xCpmdc3uKNOEr6J3WDocze9wc0h2ZmM=; b=YgxLgC0qFsP6qBeDzePUHdhKfaSnyCriDXQduA4vNZ2gfH+dGFCs7L34sq/MLrrHEr E/BVJeVxczqEMn0TcvAf0YuxDaMEZ+lcZXkNVQmISHoklQMN0QQYvyYlJcAW91c6GjBz 5L6TWK4yDZQhR1RAohbdaaf45amxc2luDHilkPwOXo2FfUe6KW+rsPfD4QboCwqnV8yM +FT2FPVlk1X6JSk8twXfcar0Yi+d286H18cTDd84+LsQ9ceiGOhlj2DZOmP9hjGy+1mJ kv9czJuWMQG/5uAekIQLb0gF2zLskf9I3CKckzsZTnTrd3IxQ9r84zFcf1i8INn/wDOC 0hWQ== X-Gm-Message-State: AOAM530+qRMy+o661K/4u9RvowMJYrGNlNFLqvY2d9myhf66G72/qVFE e2CE6ovzWaWU4fHvliyIXnQtwsgvbD4= X-Google-Smtp-Source: ABdhPJw2aTd7yAr4SUbGmPMJWsIKEBFDkCBMZa3fEXe3PwFZatbHnmq3iuEWr++ThFEMIu3idugT0g== X-Received: by 2002:a7b:c24c:: with SMTP id b12mr7873743wmj.167.1612015508595; Sat, 30 Jan 2021 06:05:08 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z130sm14048273wmb.33.2021.01.30.06.05.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 30 Jan 2021 06:05:07 -0800 (PST) In-Reply-To: <87o8h70wsx.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:198935 Archived-At: On 30.01.2021 08:21, Lars Ingebrigtsen wrote: > Dmitry Gutov writes: > >> Not sure if we should close this now. > > I think we should make the "*" area also clickable -- I think that's the > most confusing part here now (that only clicking the status area toggles > the "*", and clicking the "*" itself doesn't do anything). I don't know if it's so confusing: after all, we have mouse-face to let the user know which area can be interacted with mouse clicks. The asterisk is not highlighted, so it's not clickable. We can change that, but how? Extend highlighting to the asterisk column? On all lines, whether the asterisk is there or not? The way that the button currently starts where the text starts looks tidy and nice, IMHO. >> While we're on the subject of buttons, I think it's odd that mouse-1 >> and mouse-2 routinely do the same thing, here and in other cases >> (e.g. links in Compilation buffers). But I suppose this is outside of >> scope for this discussion. > > Yeah, the mouse thing is pretty confusing, but the > `mouse-1-click-follows-link' variable can be set to change the > behaviour. All right. And I guess (setq mouse-1-click-follows-link nil) can be a solution for the original complaint here.