unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Ergus <spacibba@aol.com>, 72263@debbugs.gnu.org
Subject: bug#72263: 31.0.50; Wrong indentation c++-ts-mode
Date: Thu, 1 Aug 2024 00:03:52 -0700	[thread overview]
Message-ID: <86C92F83-D334-4029-8AD2-B9D5BAD620D9@gmail.com> (raw)
In-Reply-To: <868qxgygpt.fsf@gnu.org>

Pushed a fix for the original bug to emacs-30. Now it indents like this:

namespace A {

  T myfunction1(const char *fname)
  {
  }

  template <class T>
  T myfunction2(const char *fname)
  {
  }
}


> On Jul 31, 2024, at 10:06 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> Date: Wed, 31 Jul 2024 23:09:53 +0200
>> From: Ergus <spacibba@aol.com>
>> CC: 72263@debbugs.gnu.org
>> 
>> I found another indentation issue in if-else conditions without
>> parenthesis:
>> 
>> if (pid == 0)
>>   print "hello from the child"
>>   else
>>   print "hello from the parent"
>> 
>> The else is not indented properly:
> 
> The above is not valid C++ code, AFAIU, so I don't understand why you
> expect c++-ts-mode to handle it properly (and what exactly is "proper"
> indentation in that case?).

As Eli said, if you add the trailing semicolon then it indents fine. If the code isn’t grammatically correct it’s hard for tree-sitter modes to indent the code.

Yuan




  reply	other threads:[~2024-08-01  7:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87cyn3vequ.fsf.ref@aol.com>
2024-07-24  0:02 ` bug#72263: 31.0.50; Wrong indentation c++-ts-mode Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25  7:29   ` Eli Zaretskii
2024-07-25  7:53     ` Yuan Fu
2024-07-31 21:09       ` Ergus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-01  5:06         ` Eli Zaretskii
2024-08-01  7:03           ` Yuan Fu [this message]
2024-08-17  7:28             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86C92F83-D334-4029-8AD2-B9D5BAD620D9@gmail.com \
    --to=casouri@gmail.com \
    --cc=72263@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=spacibba@aol.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).