From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: jxa127@verizon.net Newsgroups: gmane.emacs.bugs Subject: bug#12787: Toolbar regression from Emacs 23 to Emacs 24 -- Save As and Help no longer available Date: Fri, 02 Nov 2012 12:29:17 -0500 (CDT) Message-ID: <8698659.1494633.1351877357323.JavaMail.root@vms170027> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1351877426 27406 80.91.229.3 (2 Nov 2012 17:30:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 2 Nov 2012 17:30:26 +0000 (UTC) Cc: jxa127@verizon.net To: 12787@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 02 18:30:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TUL4k-0002H6-7Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Nov 2012 18:30:34 +0100 Original-Received: from localhost ([::1]:50963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUL4b-00044p-J3 for geb-bug-gnu-emacs@m.gmane.org; Fri, 02 Nov 2012 13:30:25 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUL4R-00044K-Ru for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:30:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUL4P-0007HD-Uv for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:30:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:35629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUL4P-0007H3-LX for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:30:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TUL78-0004Ve-H8 for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: jxa127@verizon.net Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Nov 2012 17:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12787 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135187754117282 (code B ref -1); Fri, 02 Nov 2012 17:33:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Nov 2012 17:32:21 +0000 Original-Received: from localhost ([127.0.0.1]:45880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUL6S-0004Uh-NP for submit@debbugs.gnu.org; Fri, 02 Nov 2012 13:32:21 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37938) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TUL6Q-0004Ua-Di for submit@debbugs.gnu.org; Fri, 02 Nov 2012 13:32:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUL3f-0006jI-Q7 for submit@debbugs.gnu.org; Fri, 02 Nov 2012 13:29:28 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:59762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUL3f-0006jE-NN for submit@debbugs.gnu.org; Fri, 02 Nov 2012 13:29:27 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37459) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUL3e-0003YF-Ib for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:29:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUL3d-0006io-BC for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:29:26 -0400 Original-Received: from vms173009pub.verizon.net ([206.46.173.9]:16529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUL3d-0006iU-6F for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 13:29:25 -0400 Original-Received: from vms170027pub.verizon.net ([unknown] [192.168.1.3]) by vms173009.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MCV00E3JF8TB010@vms173009.mailsrvcs.net> for bug-gnu-emacs@gnu.org; Fri, 02 Nov 2012 12:29:17 -0500 (CDT) Original-Received: from 63.66.64.247 ([63.66.64.247]) by vms170027 (Verizon Webmail) with HTTP; Fri, 02 Nov 2012 12:29:17 -0500 (CDT) X-Mailer: Verizon Webmail X-Originating-IP: [63.66.64.247] X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66349 Archived-At: The "Save As" and "Help" buttons from the tool bar are no longer available in Emacs 24. This change was not identified in the News. My attempts to replace them fail. I make the following changes in tool-bar.el: -------------------------------------------------------------- (defun tool-bar-setup () (setq tool-bar-separator-image-expression (tool-bar--image-expression "separator")) (tool-bar-add-item-from-menu 'find-file "new" nil :label "New File" :vert-only t) (tool-bar-add-item-from-menu 'menu-find-file-existing "open" nil :label "Open" :vert-only t) (tool-bar-add-item-from-menu 'dired "diropen" nil :vert-only t) (tool-bar-add-item-from-menu 'kill-this-buffer "close" nil :vert-only t) (tool-bar-add-item-from-menu 'save-buffer "save" nil :label "Save") ;; ---> I add the ?Save As? button here: (tool-bar-add-item-from-menu 'write-file "saveas" nil :label "Save as") (define-key-after (default-value 'tool-bar-map) [separator-1] menu-bar-separator) (tool-bar-add-item-from-menu 'undo "undo" nil) (define-key-after (default-value 'tool-bar-map) [separator-2] menu-bar-separator) (tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [cut]) "cut" nil :vert-only t) (tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [copy]) "copy" nil :vert-only t) (tool-bar-add-item-from-menu (lookup-key menu-bar-edit-menu [paste]) "paste" nil :vert-only t) (define-key-after (default-value 'tool-bar-map) [separator-3] menu-bar-separator) (tool-bar-add-item-from-menu 'isearch-forward "search" nil :label "Search" :vert-only t) ;;(tool-bar-add-item-from-menu 'ispell-buffer "spell") ;; There's no icon appropriate for News and we need a command rather ;; than a lambda for Read Mail. ;;(tool-bar-add-item-from-menu 'compose-mail "mail/compose") ;; ---> I uncomment the help button here: ;; Help button on a tool bar is rather non-standard... (let ((tool-bar-map (default-value 'tool-bar-map))) (tool-bar-add-item "help" (lambda () (interactive) (popup-menu menu-bar-help-menu)) 'help :help "Pop up the Help menu")) ) -------------------------------------------------------------- I save tool-bar.el, compile it to tool-bar.elc and then restart Emacs, but the buttons are not there. I can evaluate portions of tool-bar.el to make the button appear during one session, but they will not appear at start-up. Thank you, Drew Ames