From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Kazuhiro Ito Newsgroups: gmane.emacs.bugs Subject: bug#40407: [PATCH] slow ENCODE_FILE and DECODE_FILE Date: Thu, 09 Apr 2020 23:09:06 +0900 Message-ID: <868sj4u4xp.wl--xmue@d1.dion.ne.jp> References: <805F9723-8298-4FD7-A47B-1E683721A5B0@acm.org> <835zegwn9y.fsf@gnu.org> <87blo46i1j.fsf@mail.parknet.co.jp> <835zecsnip.fsf@gnu.org> <5D4B264A-C43B-4CEE-91DE-760AEBE80671@acm.org> <83zhbor2ur.fsf@gnu.org> <329AEABE-0D33-4324-B697-FBEA9340E6BB@acm.org> <83wo6sr0s2.fsf@gnu.org> <83tv1wqxwh.fsf@gnu.org> <87lfn84g5h.fsf@mail.parknet.co.jp> <31072A44-E59A-47A9-83DE-CDD747BC6105@acm.org> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="31746"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 EasyPG/1.0.0 Emacs/28.0 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) Cc: 40407@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 09 16:10:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jMXsh-0008AX-GQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Apr 2020 16:10:11 +0200 Original-Received: from localhost ([::1]:50570 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMXsg-0001nq-Je for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Apr 2020 10:10:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38022) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jMXsZ-0001nf-5J for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 10:10:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jMXsY-0005Vd-7e for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 10:10:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42731) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jMXsY-0005VW-4t for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 10:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jMXsX-00022f-VU for bug-gnu-emacs@gnu.org; Thu, 09 Apr 2020 10:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Apr 2020 14:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40407 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 40407-submit@debbugs.gnu.org id=B40407.15864413537788 (code B ref 40407); Thu, 09 Apr 2020 14:10:01 +0000 Original-Received: (at 40407) by debbugs.gnu.org; 9 Apr 2020 14:09:13 +0000 Original-Received: from localhost ([127.0.0.1]:54277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMXrl-00021Y-Lc for submit@debbugs.gnu.org; Thu, 09 Apr 2020 10:09:13 -0400 Original-Received: from snd00010.auone-net.jp ([111.86.247.10]:44897 helo=dmta0007.auone-net.jp) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jMXrj-00021N-6t for 40407@debbugs.gnu.org; Thu, 09 Apr 2020 10:09:13 -0400 Original-Received: from kzhr.d1.dion.ne.jp by dmta0007.auone-net.jp with ESMTP id <20200409140908385.CJCJ.97964.kzhr.d1.dion.ne.jp@dmta0007.auone-net.jp>; Thu, 9 Apr 2020 23:09:08 +0900 In-Reply-To: <31072A44-E59A-47A9-83DE-CDD747BC6105@acm.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:178169 Archived-At: On Thu, 09 Apr 2020 20:03:51 +0900, Mattias Engdeg=E5rd wrote: >=20 > Eli, thank you very much for thinking about EOL conversion; > obviously I didn't. I fixed a couple of glitches: a variable was > used uninitialised, the logic didn't quite work for both unibyte and > multibyte, and unless I'm mistaken it's LF that we should look for > when encoding, not CR? Anyway, hope you don't mind. I noticed that last-coding-system-used was not set when the fast path was used. (let ((string "ABCD\r\nEFGH") inhibit-eol-conversion) (decode-coding-string string 'raw-text-dos) (decode-coding-string string 'raw-text-unix) last-coding-system-used) -> raw-text-dos --=20 Kazuhiro Ito