unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 52237@debbugs.gnu.org
Subject: bug#52237: 29.0.50; [PATCH 2] Doubled separators in context-menu-mode
Date: Sun, 05 Dec 2021 11:32:42 +0200	[thread overview]
Message-ID: <868rwzcrql.fsf@mail.linkov.net> (raw)
In-Reply-To: <ea800e78-c137-ea02-f1e4-6dc67c668404@gmail.com> (Jim Porter's message of "Thu, 2 Dec 2021 20:46:28 -0800")

> Ok, here's a patch to do it. There might be a better way to do this, but it
> should work reliably.
>
> -      (while (consp l)
> +      (while (consp (cdr l))

This change broke flyspell-correct-word.  When a context menu is invoked
on a misspelled word in flyspell-mode, context-menu-map uses the property
context-menu-function to get a command symbol 'flyspell-correct-word'
instead of a list of menu items.

bug#50851 fixed this error by checking for a list with `(consp l)' like above:

  (consp 'flyspell-correct-word) => nil

but now 'cdr' fails on (consp (cdr 'flyspell-correct-word)).





  parent reply	other threads:[~2021-12-05  9:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-02  6:06 bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Jim Porter
2021-12-02  8:24 ` Lars Ingebrigtsen
2021-12-02 17:44   ` Juri Linkov
2021-12-03  4:46     ` bug#52237: 29.0.50; [PATCH 2] " Jim Porter
2021-12-03 16:10       ` Lars Ingebrigtsen
2021-12-05  9:32       ` Juri Linkov [this message]
2021-12-05 20:20         ` Lars Ingebrigtsen
2021-12-03 16:08     ` bug#52237: 29.0.50; [PATCH] " Lars Ingebrigtsen
2021-12-04  6:44       ` Jim Porter
2021-12-04  8:26         ` Eli Zaretskii
2021-12-02 17:31 ` bug#52237: [External] : " Drew Adams
2021-12-02 18:09   ` Jim Porter
2021-12-02 18:25     ` bug#52237: [External] : " Drew Adams
2021-12-02 18:47 ` Jim Porter
2021-12-04 19:50   ` Juri Linkov
2021-12-04 20:56     ` Jim Porter
2021-12-04 22:09       ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868rwzcrql.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=52237@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).