From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Thu, 25 May 2023 21:41:32 +0300 Organization: LINKOV.NET Message-ID: <868rdcfe3n.fsf@mail.linkov.net> References: <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> <835y8otbub.fsf@gnu.org> <86o7mccl5z.fsf@mail.linkov.net> <63854a1a-8178-d039-288c-34b1e67e5b06@gutov.dev> <86ttw3blc6.fsf@mail.linkov.net> <86sfbm6hp5.fsf@mail.linkov.net> <86jzwyw8j5.fsf@mail.linkov.net> <6a5c2251-52a8-e389-f2ab-08da775fab82@gutov.dev> <867csw53fm.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23606"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: sbaugh@janestreet.com, Eli Zaretskii , 63469@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 25 20:43:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2Fvo-00062F-68 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 May 2023 20:43:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2FvT-0007Cf-6o; Thu, 25 May 2023 14:43:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2FvS-0007CW-Gm for bug-gnu-emacs@gnu.org; Thu, 25 May 2023 14:43:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2FvS-0005D6-8w for bug-gnu-emacs@gnu.org; Thu, 25 May 2023 14:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2FvS-0000UO-40 for bug-gnu-emacs@gnu.org; Thu, 25 May 2023 14:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 May 2023 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.16850401681858 (code B ref 63469); Thu, 25 May 2023 18:43:02 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 25 May 2023 18:42:48 +0000 Original-Received: from localhost ([127.0.0.1]:48131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2FvE-0000Tu-IJ for submit@debbugs.gnu.org; Thu, 25 May 2023 14:42:48 -0400 Original-Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2FvC-0000Tf-Qy for 63469@debbugs.gnu.org; Thu, 25 May 2023 14:42:47 -0400 X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net X-GND-Sasl: juri@linkov.net Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id EFF37FF804; Thu, 25 May 2023 18:42:39 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Thu, 25 May 2023 19:14:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262387 Archived-At: >>> -(cl-defmethod project-name ((_project (head vc))) >>> - (or project-vc-name >>> +(cl-defmethod project-name ((project (head vc))) >>> + (or (project--value-in-dir 'project-vc-name (project-root project)) >>> (cl-call-next-method))) >> Thanks, I confirm this uses project-vc-name from dir-locals in non-file >> buffers. > > If you had a chance to verify that the performance is good enough (for > using the result in the mode-line), that would be great. > > Either way... > >>>> ;;;###autoload(put 'compilation-directory 'safe-local-variable 'stringp) >>> >>> Huh, so the attribute :safe only makes proper sense for preloaded packages >>> and autoloaded defcustom forms (which are discouraged anyway). >>> >>> Do you want to write a patch for all those vars in project.el? It will >>> probably make sense to push it to emacs-29. >> With this patch the problem is solved. I can push it to emacs-29. > > ...this patch LGTM too. Please go ahead and install it, or even both > patches. I pushed ###autoload to emacs-29. But not sure about your patch since currently I have no idea how to verify its performance. Maybe it should be pushed to master so that everyone can test it?