From: Eli Zaretskii <eliz@gnu.org>
To: Matt <matt@excalamus.com>
Cc: 69745-done@debbugs.gnu.org, schwab@suse.de
Subject: bug#69745: [PATCH] Fix incorrect Edebug docstrings
Date: Sat, 16 Mar 2024 12:43:40 +0200 [thread overview]
Message-ID: <868r2i78yr.fsf@gnu.org> (raw)
In-Reply-To: <18e43236053.ea8d2a62434521.1358079795129399231@excalamus.com> (message from Matt on Fri, 15 Mar 2024 18:22:55 +0100)
> Cc: 69745 <69745@debbugs.gnu.org>
> Date: Fri, 15 Mar 2024 18:22:55 +0100
> From: Matt <matt@excalamus.com>
>
> Thanks for taking the time to review this.
>
> You are correct in the functioning. The problem is the current docstrings are ambiguous. Consider the current description for 'edebug-print-length':
>
> "If non-nil, default value of ‘print-length’ for printing results in Edebug."
>
> This has, at least, two possible interpretations:
>
> 1. "If non-nil, USE THE VALUE OF EDEBUG-PRINT-LENGTH FOR THE default value of 'print-length' for printing results in Edebug."
> 2. "If non-nil, USE THE default value of 'print-length' for printing results in Edebug."
>
> As you point out, the first meaning is the intended one based on the implementation. I read it according to the second interpretation.
>
> Without getting hung up on why it's ambiguous, I hope I've made the case that it is ambiguous.
>
> I've updated the patch to use the same wording as 'print-length' and 'print-level' which hopefully makes things clear. The current docstring felt it necessary to explicitly mention "for printing results in Edebug" and I've tried to preserve that in the suggested changes.
Thanks, I installed a variant of this on the emacs-29 branch, and I'm
therefore closing this bug.
prev parent reply other threads:[~2024-03-16 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 9:13 bug#69745: [PATCH] Fix incorrect Edebug docstrings Matt
2024-03-12 12:59 ` Andreas Schwab
2024-03-15 17:22 ` Matt
2024-03-16 10:43 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868r2i78yr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69745-done@debbugs.gnu.org \
--cc=matt@excalamus.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).