From: Eli Zaretskii <eliz@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 70216@debbugs.gnu.org
Subject: bug#70216: 30.0.50; self-insert-command doesn't respect create-lockfiles
Date: Fri, 05 Apr 2024 16:03:31 +0300 [thread overview]
Message-ID: <868r1s55cs.fsf@gnu.org> (raw)
In-Reply-To: <87zfu8w07c.fsf@thornhill.no> (bug-gnu-emacs@gnu.org)
> Date: Fri, 05 Apr 2024 12:52:39 +0200
> From: Theodor Thornhill via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> I'm digging more and more into the internals of Emacs these days, and
> while tracing input lag performance i noticed that we don't respect the
> create-lockfiles option, at least not fully.
>
> The documentation states:
> ```
> If the option `create-lockfiles' is nil, this does nothing.
> ```
I guess we need to fix the documentation, then.
> However, the nothing is postponed until later, inside the lock_file
> function. This means we won't cretae the lockfile, but we will get the
> truename-buffer, verify visited file, etc, on my system amounting to
> some time spent which I thought I opted out of.
This is on purpose. We decided that create-lockfiles = nil is meant
to disable the creation of lock files, but it is not meant to disable
userlock--ask-user-about-supersession-threat, for example, which is an
important feature we don't want to lose just because the user doesn't
want to have lock files. See bug#53207 for some discussion of this.
Bug#49507 is also relevant.
> Along with a patch that fixes this behavior I've added 4 screenshots of
> graphs taken through intel_pt tracing on trigger of self-insert inside a
> c file.
I don't think we want to install this patch, since we do want the
file-change detection, which is done as part of this code.
> The lock file related code can take up to a millisecond on my system,
> but is usually in the range of 200-300 microseconds.
Lock files and file-change detection are Emacs safety measures that
are important on any modern OS. Disabling them because they eat up
CPU cycles is wrong, from where I stand. That said, hundreds of
milliseconds for 2 calls to 'stat' sounds excessive to me, so please
tell more details and try to show the breakdown of this long time.
> It seems there was some cleanup/changes around this behavior which i
> believe caused this as a regression, from around 3 years ago. I _think_
> this commit: 9ce6541ac9710933beca7f9944087fe4849d5ae9
There were more changes there, see above.
next prev parent reply other threads:[~2024-04-05 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 10:52 bug#70216: 30.0.50; self-insert-command doesn't respect create-lockfiles Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-05 13:03 ` Eli Zaretskii [this message]
[not found] ` <87il0up4bv.fsf@thornhill.no>
2024-04-07 6:31 ` Eli Zaretskii
2024-04-07 6:40 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-07 8:11 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868r1s55cs.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70216@debbugs.gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).