From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70271: 30.0.50; [PATCH] * lisp/ls-lisp.el (ls-lisp--sanitize-switches): support more Date: Tue, 09 Apr 2024 06:24:23 +0300 Message-ID: <868r1nxlp4.fsf@gnu.org> References: <86bk6kyu41.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2078"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70271-done@debbugs.gnu.org To: Lin Sun Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 09 05:25:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ru270-0000Ms-My for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Apr 2024 05:25:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ru26T-0003bl-Eu; Mon, 08 Apr 2024 23:24:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru26S-0003bD-0t for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 23:24:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru26R-0005W1-Ou for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 23:24:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ru26Z-0007nM-GE for bug-gnu-emacs@gnu.org; Mon, 08 Apr 2024 23:25:03 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Apr 2024 03:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70271 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 70271@debbugs.gnu.org, eliz@gnu.org, sunlin7.mail@gmail.com Original-Received: via spool by 70271-done@debbugs.gnu.org id=D70271.171263308029762 (code D ref 70271); Tue, 09 Apr 2024 03:25:03 +0000 Original-Received: (at 70271-done) by debbugs.gnu.org; 9 Apr 2024 03:24:40 +0000 Original-Received: from localhost ([127.0.0.1]:47959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru26B-0007jv-Fl for submit@debbugs.gnu.org; Mon, 08 Apr 2024 23:24:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru269-0007jI-8M for 70271-done@debbugs.gnu.org; Mon, 08 Apr 2024 23:24:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru25w-0005S1-5G; Mon, 08 Apr 2024 23:24:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JHHzVb0GVMEUBMiX5CSgechTagsbpQ5QQTjsPgtngEk=; b=HpWQc3IsMHiCg6PjLXYN ul2EPBZU3OKwQOMH3JX+2LBvOu3bQ8EPX50tYWgvb8vcvGqQK0EPzCulK+oBdz1KeFXtuKANpIFg6 e2QQav9ZwDVlzZNxWJtfXf4JkY8MQw8y3G5OlF8hW+0HoYhLyqVFQUHzm2Cz+Ia5GB0JWfN4xwQ9e rm9YRvybNkRmdPu6H4XIqJAPeQVVNFl8xlaTbNBpfbgfVeE/JI7wmgvw58kND3MJmXIEIyuBYe+Lq /f9amhVCWqBwJ7wea4hC74Pgt8/PxnHt8fWjlZS1zCALnXAv3nGI4dqzYWh8m+tAJNOVi+sqygqD8 Ela4HYp6QCUKiw==; In-Reply-To: (message from Lin Sun on Mon, 8 Apr 2024 20:43:54 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282960 Archived-At: > From: Lin Sun > Date: Mon, 8 Apr 2024 20:43:54 +0000 > Cc: 70271@debbugs.gnu.org > > On Mon, Apr 8, 2024 at 11:25 AM Eli Zaretskii wrote: > > > > > From: Lin Sun > > > Date: Mon, 8 Apr 2024 05:10:22 +0000 > > > > > > The dired ignored the options like "--time=ctime" in the variable > > > `dired-listing-switches' on Windows OS. > > > > > > I traced the code and found dired will use the functions in the > > > `ls-lisp.el' instead of calling the real command "/usr/bin/ls", and > > > the "ls-lisp.el" didn't process the "--time=ctime" option. > > > > > > The attached PATCH will convert the "--time=ctime" to "-c"... in the > > > "ls-lisp.el", and then the dired will display the desired time in its > > > time column. > > > > > > Here is the verification code (on Windows OS), try it one line and > > > close the dired buffer then try next line. > > > > > > (dired "/tmp/aa" "-al --sort=time") ; as "-al -t" > > > > > > (dired "/tmp/aa" "-al --time=ctime") ; as "al -c" > > > > > > (dired "/tmp/aa" "-al --time=atime") ; as "al -u" > > > > > > Please help review the changes and approve them. Thanks > > > > Thanks, but how about adding some tests for this? > > Sure, I had added the test case for this ticket. > > Changes are attached in the PATCH. Thanks, installed on master, and closing the bug. The test had a small bug, I fixed it. Also, please look at how I modified the commit log message, and in the future try following our conventions more closely (capitalization of log entries, specifying function names, etc.)