unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Joost Kremers <joostkremers@fastmail.fm>
Cc: adam@alphapapa.net, 70664@debbugs.gnu.org
Subject: bug#70664: 29.3; vtable-insert-object cannot insert at top of table
Date: Thu, 09 May 2024 11:45:57 +0300	[thread overview]
Message-ID: <868r0j74qi.fsf@gnu.org> (raw)
In-Reply-To: <868r0levw7.fsf@fastmail.fm> (message from Joost Kremers on Tue,  07 May 2024 12:52:56 +0200)

> From: Joost Kremers <joostkremers@fastmail.fm>
> Cc: Eli Zaretskii <eliz@gnu.org>,  70664@debbugs.gnu.org
> Date: Tue, 07 May 2024 12:52:56 +0200
> 
> Here's my first attempt at fixing this bug and generally making
> `vtable-insert-object` more versatile (see attachment).

Thanks.

> A few questions / comments:
> 
> - Is this the right place to send this patch? Or should it go to emacs-devel?

Here is the right place for patches.

> - I don't know if this change warrants a NEWS entry. It's not really
>   user-facing, so I didn't add one.

This changes a public API, so it does need to be called out in NEWS,
just in the section which lists Lisp-level changes.

> - I don't know how to write a non-interactive test for my changes, because
>   `vtable-insert-object` only works if the vtable is being displayed in a
>   buffer. So instead I wrote an interactive function to test all possible
>   combinations of LOCATION and BEFORE:

A test can be interactive (since the test suite can be run
interactively as well), but then please skip the test if it's run in
batch mode.

> +@defun vtable-insert-object table object &optional location before
> +Insert @var{object} into @var{table}.  @var{location} should be an
> +object in the table, the new object is inserted after this object, or
> +before it if @var{before} is non-nil.  If @var{location} is nil,
                                    ^^^                        ^^^
@code{nil}, in both cases.

> +;; FIXME: The fact that the `location' argument of
> +;; `vtable-insert-object' can be an integer and is then interpreted as
> +;; an index precludes the use of integers as objects. This seems a very
                                                       ^^
Two spaces between sentences, please.





  reply	other threads:[~2024-05-09  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  9:30 bug#70664: 29.3; vtable-insert-object cannot insert at top of table Joost Kremers
2024-04-30 12:18 ` Eli Zaretskii
     [not found]   ` <d55f9a57-c9aa-439e-b8e1-004f445f1a24@alphapapa.net>
2024-05-02  6:52     ` Joost Kremers
2024-05-02  9:54       ` Adam Porter
2024-05-02 10:12         ` Joost Kremers
2024-05-03  4:16           ` Adam Porter
2024-05-07 10:52             ` Joost Kremers
2024-05-09  8:45               ` Eli Zaretskii [this message]
2024-05-09 16:45                 ` Joost Kremers
2024-05-18  8:54                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868r0j74qi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70664@debbugs.gnu.org \
    --cc=adam@alphapapa.net \
    --cc=joostkremers@fastmail.fm \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).