From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies Date: Thu, 13 Jun 2024 18:33:37 +0300 Message-ID: <868qz8zwku.fsf@gnu.org> References: <6b02899a34d61995765d18f245dd33c5@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4601"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71537@debbugs.gnu.org To: Gerard Vermeulen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 13 17:36:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sHmUs-0000y3-BY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jun 2024 17:36:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sHmUe-00006e-OG; Thu, 13 Jun 2024 11:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHmUd-00006D-32 for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 11:36:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sHmUc-0001vF-Qp for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 11:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sHmUc-0006Z9-As for bug-gnu-emacs@gnu.org; Thu, 13 Jun 2024 11:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jun 2024 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71537 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71537-submit@debbugs.gnu.org id=B71537.171829295925228 (code B ref 71537); Thu, 13 Jun 2024 15:36:02 +0000 Original-Received: (at 71537) by debbugs.gnu.org; 13 Jun 2024 15:35:59 +0000 Original-Received: from localhost ([127.0.0.1]:33566 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHmUZ-0006Yo-49 for submit@debbugs.gnu.org; Thu, 13 Jun 2024 11:35:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sHmUX-0006YV-C9 for 71537@debbugs.gnu.org; Thu, 13 Jun 2024 11:35:58 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sHmSM-0001RP-4K; Thu, 13 Jun 2024 11:33:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QiydbmUrKmmX3Ok6G2RFT1N6p/wfZrgQVM0z/ZQwQXE=; b=pdMOFSRub8NG qeUtG9PjSJvKe31m0IIHshKpAuW8iTk6cyLiF1q3rnZ4UhxwYzet0gTQCYdJ3gAto9ekGGvjXZKbJ 56XRr1LVvJibdbPX68WvdDOR8UTjpyDU/JNhOc8MB+4AAQTKZLwReeHuLk7mEOzhNzBQ+ojfaUsjl 6lZbfdYHaKVLu4TP3L5dLaDtnQSzGWNmmHX5YnZ7pRo+5YQdrSsQpwLhU09dO58fmC8Q16i+qCsO4 hc6S08pn2ybUQP4EAEKKHOF6drluy2imXc0f7qJ/RphoU6hoeURqZ3LFkUIFoBxNPLAKFYcus9KCM 1B45oPMBeydY3JzgJWqG4g==; In-Reply-To: <6b02899a34d61995765d18f245dd33c5@posteo.net> (message from Gerard Vermeulen on Thu, 13 Jun 2024 14:59:06 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287200 Archived-At: > Date: Thu, 13 Jun 2024 14:59:06 +0000 > From: Gerard Vermeulen > > I propose the attached patch adding three missing autoload cookies > to eliminate two require forms from two sections in my init.el. > > To eliminate (require 'shortdoc) from the first section: > (with-eval-after-load 'help-fns > ;; ChatGPT recommends to require `shortdoc' contrary to the > ;; `shortdoc-help-fns-examples-function' documentation string. > (require 'shortdoc) > (add-hook 'help-fns-describe-function-functions > #'shortdoc-help-fns-examples-function) > (setopt help-enable-symbol-autoload t)) > > And to eliminate (require 'pulse) from the second section: > (require 'pulse) ; since `pulse' does not autoload `pulse-delay' and > ; `pulse-iterations'. > > (defun flash-line-around-point (&rest _) > "Flash the line around point." > (let ((pulse-iterations 16) > (pulse-delay 0.1)) > (pulse-momentary-highlight-one-line (point)))) > > (dolist (command '(scroll-up-command > scroll-down-command > recenter-top-bottom > other-window)) > (advice-add command :after #'flash-line-around-point)) Thanks, but I don't understand why what we have now constitutes a problem. help-fns loads shortdoc when it needs it, and pulse-momentary-highlight-one-line is autoloaded already (you don't need to auto-load variables to assign values to them). Can you describe the problems you have if you delete those 'require's from your init file, and explain why manually requiring them is a problem?