From: Eli Zaretskii <eliz@gnu.org>
To: Gerard Vermeulen <gerard.vermeulen@posteo.net>
Cc: 71537@debbugs.gnu.org
Subject: bug#71537: 30.0.50; [PATCH] missing autoload cookies
Date: Thu, 13 Jun 2024 18:33:37 +0300 [thread overview]
Message-ID: <868qz8zwku.fsf@gnu.org> (raw)
In-Reply-To: <6b02899a34d61995765d18f245dd33c5@posteo.net> (message from Gerard Vermeulen on Thu, 13 Jun 2024 14:59:06 +0000)
> Date: Thu, 13 Jun 2024 14:59:06 +0000
> From: Gerard Vermeulen <gerard.vermeulen@posteo.net>
>
> I propose the attached patch adding three missing autoload cookies
> to eliminate two require forms from two sections in my init.el.
>
> To eliminate (require 'shortdoc) from the first section:
> (with-eval-after-load 'help-fns
> ;; ChatGPT recommends to require `shortdoc' contrary to the
> ;; `shortdoc-help-fns-examples-function' documentation string.
> (require 'shortdoc)
> (add-hook 'help-fns-describe-function-functions
> #'shortdoc-help-fns-examples-function)
> (setopt help-enable-symbol-autoload t))
>
> And to eliminate (require 'pulse) from the second section:
> (require 'pulse) ; since `pulse' does not autoload `pulse-delay' and
> ; `pulse-iterations'.
>
> (defun flash-line-around-point (&rest _)
> "Flash the line around point."
> (let ((pulse-iterations 16)
> (pulse-delay 0.1))
> (pulse-momentary-highlight-one-line (point))))
>
> (dolist (command '(scroll-up-command
> scroll-down-command
> recenter-top-bottom
> other-window))
> (advice-add command :after #'flash-line-around-point))
Thanks, but I don't understand why what we have now constitutes a
problem. help-fns loads shortdoc when it needs it, and
pulse-momentary-highlight-one-line is autoloaded already (you don't
need to auto-load variables to assign values to them).
Can you describe the problems you have if you delete those 'require's
from your init file, and explain why manually requiring them is a
problem?
next prev parent reply other threads:[~2024-06-13 15:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 14:59 bug#71537: 30.0.50; [PATCH] missing autoload cookies Gerard Vermeulen
2024-06-13 15:33 ` Eli Zaretskii [this message]
2024-06-13 20:57 ` Gerard Vermeulen
2024-06-14 6:43 ` Eli Zaretskii
2024-06-14 8:29 ` Gerard Vermeulen
2024-06-14 11:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868qz8zwku.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=71537@debbugs.gnu.org \
--cc=gerard.vermeulen@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).