From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Date: Sat, 06 Jul 2024 10:50:32 +0300 Message-ID: <868qyf5587.fsf@gnu.org> References: <865xtu7seh.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 06 09:53:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQ0EI-0000HP-5l for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jul 2024 09:53:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQ0E8-00018p-11; Sat, 06 Jul 2024 03:53:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ0E6-00018f-Dp for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 03:52:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQ0E6-00081O-5G for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 03:52:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQ0E9-0005jz-KF for bug-gnu-emacs@gnu.org; Sat, 06 Jul 2024 03:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jul 2024 07:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71504 X-GNU-PR-Package: emacs Original-Received: via spool by 71504-submit@debbugs.gnu.org id=B71504.172025237522047 (code B ref 71504); Sat, 06 Jul 2024 07:53:01 +0000 Original-Received: (at 71504) by debbugs.gnu.org; 6 Jul 2024 07:52:55 +0000 Original-Received: from localhost ([127.0.0.1]:45524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ0E2-0005jX-VY for submit@debbugs.gnu.org; Sat, 06 Jul 2024 03:52:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQ0E0-0005jJ-TJ for 71504@debbugs.gnu.org; Sat, 06 Jul 2024 03:52:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQ0Bl-0007D5-KS; Sat, 06 Jul 2024 03:50:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QxTHfiJMBY963l0nufbjpH9lSHqO08H+3CnbibW4xL8=; b=Od/Rhv5nw0e+ 5bYddeaOmfxcsayVLH33BBHIMcx690zRomaM0fCaBsO3FjPW/P7vsND6+279pd63b/jDhZfr+8Dgw pJ8M4I8hBqS081kMMJZahpyu4VLwxh7Ae+2Eb0kiIhI+h1GnnZB+5K3EbXog/VjGrWuYmwEWAeL9E KQWR1n9ik7ROKgnKO1tX/EI1ThsgwDWy9k7joRPcijH8DBhI3vH07B7/KU3kdPg9tOhyv5pQAGnU2 +6M3Ik8uWZisnDhqe7ufmhPgqUMChuciXKi1T45rgy367MKFkzG1p1KbJqsiQIBdlMA1aA8+HKqdc 2p2ZNjP1+X+RrFXF/LDKAw==; In-Reply-To: (message from Eshel Yaron on Thu, 27 Jun 2024 20:15:37 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288471 Archived-At: > From: Eshel Yaron > Cc: Eli Zaretskii , 71504@debbugs.gnu.org > Date: Thu, 27 Jun 2024 20:15:37 +0200 > > Spencer Baugh writes: > > > Eli Zaretskii writes: > >>> Date: Wed, 12 Jun 2024 10:43:14 +0200 > >>> From: Eshel Yaron via "Bug reports for GNU Emacs, > >>> the Swiss army knife of text editors" > >>> > >>> Following a recent short discussion[0] on emacs-devel, I'm opening this > >>> feature request so it doesn't get lost: > >>> > >>> Flymake should provide a standard way for backends to associate fix > >>> suggestions with the diagnostics they produce, along with a > >>> backend-agnostic user interface (e.g. a command) for examining and > >>> applying such fixes. > >>> > >>> I suggested a possible implementation that works quite well for me > >>> (with the three backends I've adapted so far - checkdoc, shellcheck > >>> and Eglot), but any other solution that gives various backends a > >>> standard way to provide their fixes would be just as welcome. > > [...] > > > I also think we have not sufficiently explored different UI > > possibilities, and I think adding to flymake now will limit us in what > > UI possibilities we can explore, no matter how generic we try to be. > > And that UI exploration can happen without adding to flymake. > > > > For example, maybe we want to have a command which can accept fixes > > output by a process running in M-x compile. Baking the UI into flymake > > would make that impossible, wouldn't it? > > I don't think adding a command for fixing the diagnostic at point should > preclude any other developments or explorations. It's a useful thing to > have, and many Flymake backends have the needed data readily available. > > > So before any change in flymake I would like to see much more > > exploration of "fix" UIs which are genuinely flymake-independent. > > Flymake shows diagnostics, and "fixing" is what we do to diagnostics. > What would be the benefit of a Flymake-independent UI for fixing the > diagnostics that Flymake already shows? The benefit would be that we will be able to use that UI when "fixes" are shown in, for example, the *compilation* buffer.