From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71504: 30.0.50; FR: Fix suggestions ("quick fix") for Flymake diagnostics Date: Sun, 07 Jul 2024 13:44:22 +0300 Message-ID: <868qyd32ih.fsf@gnu.org> References: <865xtu7seh.fsf@gnu.org> <868qyf5587.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4486"; mail-complaints-to="usenet@ciao.gmane.io" Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 07 12:45:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQPOK-00011o-Bm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jul 2024 12:45:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQPO7-0002ah-QY; Sun, 07 Jul 2024 06:44:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQPO6-0002aZ-M9 for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 06:44:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQPO6-0000gs-44 for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 06:44:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sQPOA-0005uY-3X for bug-gnu-emacs@gnu.org; Sun, 07 Jul 2024 06:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jul 2024 10:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71504 X-GNU-PR-Package: emacs Original-Received: via spool by 71504-submit@debbugs.gnu.org id=B71504.172034908222682 (code B ref 71504); Sun, 07 Jul 2024 10:45:02 +0000 Original-Received: (at 71504) by debbugs.gnu.org; 7 Jul 2024 10:44:42 +0000 Original-Received: from localhost ([127.0.0.1]:47473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQPNq-0005tm-14 for submit@debbugs.gnu.org; Sun, 07 Jul 2024 06:44:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sQPNn-0005tY-AM for 71504@debbugs.gnu.org; Sun, 07 Jul 2024 06:44:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQPNc-0000dT-Oz; Sun, 07 Jul 2024 06:44:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+gcrUHcxjlRNQymtrvFAE7f+SphLfVG1kUOLf/DcUpE=; b=Xe/V2JF+alGr 3ptXd+St28Z2kq/xCM6ypZGmUbvx3bHXROwxr+H2LlSkzAVY5qGttJtGDKiW1tzO0ElaLbrSgKIFz jlN7lYGZ5EboAqy7fSAVxWWPHFbubCt+tdLPe8vOOf8HniPr3deHahBp/KQF17rk+2kqY6GdB+4LQ iqrCg9akHMN1P1i6A7t9Yo6/bHIhr5epcXPX2Rp7B+1qbxwtCNwdwJdfSC82voWSR0Fjz3fJ0kNQs 5t0clwsVY4UikynsrmM9T3Ej7Y3W7zF/D1hlImd7phhsAvOturQ0Lv99/v1Ql2oWNOhU5hhKmuVvJ p0USQ+E0N3hXz79OBkdLhA==; In-Reply-To: (message from Eshel Yaron on Sun, 07 Jul 2024 10:53:12 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288555 Archived-At: > From: Eshel Yaron > Cc: sbaugh@janestreet.com, 71504@debbugs.gnu.org > Date: Sun, 07 Jul 2024 10:53:12 +0200 > > >> From: Eshel Yaron > >> Cc: Eli Zaretskii , 71504@debbugs.gnu.org > >> Date: Thu, 27 Jun 2024 20:15:37 +0200 > >> > >> Spencer Baugh writes: > >> > >> > For example, maybe we want to have a command which can accept fixes > >> > output by a process running in M-x compile. Baking the UI into flymake > >> > would make that impossible, wouldn't it? > >> > >> I don't think adding a command for fixing the diagnostic at point should > >> preclude any other developments or explorations. It's a useful thing to > >> have, and many Flymake backends have the needed data readily available. > >> > >> > So before any change in flymake I would like to see much more > >> > exploration of "fix" UIs which are genuinely flymake-independent. > >> > >> Flymake shows diagnostics, and "fixing" is what we do to diagnostics. > >> What would be the benefit of a Flymake-independent UI for fixing the > >> diagnostics that Flymake already shows? > > > > The benefit would be that we will be able to use that UI when "fixes" > > are shown in, for example, the *compilation* buffer. > > It'd be good to enhance compilation buffers as well, but this feature > request is about interaction with Flymake diagnostics, that are shown in > the diagnosed buffer: I'd like to have a standard way to act on (fix) > the diagnostic at point. I frankly don't understand what you are saying here. Several people opined that we should take a broader view on the fixes and how to handle them, but you insist that Flymake should have its own solution? IOW, the "fixes" diagnostic shown by Flymake is not just diagnostic, it's a suggestion to make some change in the source code. So supporting that cannot be separated from the more general concept of making changes proposed by some external tool. Or what am I missing? Or maybe this is a simple misunderstanding: what do you mean by "acting on diagnostic at point", and how could such an act be indifferent to what and how is fixed?