unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 72147@debbugs.gnu.org, Visuwesh <visuweshm@gmail.com>
Subject: bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command
Date: Tue, 23 Jul 2024 20:40:47 +0300	[thread overview]
Message-ID: <868qxsyq0o.fsf@mail.linkov.net> (raw)
In-Reply-To: <87ed7k4fwd.fsf@web.de> (Michael Heerdegen's message of "Tue, 23 Jul 2024 11:27:30 +0200")

>> Thanks for the patch, now pushed to master.
>
> Wouldn't it be better to add a new optional argument NO-HIGHLIGHT to
> `query-replace-read-args', for stylistic reasons?

It's not clear how such arg should be combined with
`query-replace-lazy-highlight' in `query-replace-read-args':

(defun query-replace-read-args (prompt regexp-flag &optional noerror no-highlight)
  ...
  (from (minibuffer-with-setup-hook
            (minibuffer-lazy-highlight-setup
             :highlight query-replace-lazy-highlight

with `and'?  With `or'?  With `xor'?
`(and query-replace-lazy-highlight (not no-highlight))'?





  reply	other threads:[~2024-07-23 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-17  3:43 bug#72147: 30.0.60; 30.0.60; Misleading regexp highlighting in 'Q' dired command Visuwesh
2024-07-19  6:50 ` Juri Linkov
2024-07-19  8:25   ` Visuwesh
2024-07-23  6:37     ` Juri Linkov
2024-07-23  9:27       ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-23 17:40         ` Juri Linkov [this message]
2024-07-24 17:09           ` Michael Heerdegen via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 18:08             ` Juri Linkov
2024-07-28  4:59               ` Visuwesh
2024-07-28  6:54                 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868qxsyq0o.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=72147@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).