From: Eli Zaretskii <eliz@gnu.org>
To: Alvaro Ramirez <alvaro@xenodium.com>
Cc: 72272@debbugs.gnu.org, acorallo@gnu.org
Subject: bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path
Date: Sat, 17 Aug 2024 11:53:36 +0300 [thread overview]
Message-ID: <868qwv4jjj.fsf@gnu.org> (raw)
In-Reply-To: <m2v80ft4wm.fsf@xenodium.com> (message from Alvaro Ramirez on Mon, 05 Aug 2024 15:34:17 +0100)
> From: Alvaro Ramirez <alvaro@xenodium.com>
> Cc: eliz@gnu.org, 72272@debbugs.gnu.org
> Date: Mon, 05 Aug 2024 15:34:17 +0100
>
> I also modified the patch a little to cater for
> `dired-maybe-insert-subdir` (see
> https://lists.gnu.org/archive/html/emacs-devel/2024-08/msg00033.html)
> and to include a couple of tests.
>
> May be worth noting, the following dired.el comment seemed
> outdated
> https://github.com/emacs-mirror/emacs/blob/c7d9cd722e5a7042a52c92f8497f903bfe9870b8/lisp/dired.el#L1805
>
> ;; Note that dired-build-subdir-alist will replace the name
> ;; by its expansion, so it does not matter whether what we insert
> ;; here is fully expanded, but it should be absolute.
>
> The mentioned replacement doesn't take place when using
> `dired-maybe-insert-subdir`, so I tweaked the comment. Setting
> invisible property is now needed in two places (to handle current
> location and now subdirs).
>
> Please take a look at the latest patch. Happy to go with a
> different direction if preferred.
Thanks, this LGTM. However, AFAIU your copyright-assignment paperwork
is not yet completed, so we should wait for that, and then we can
install.
next prev parent reply other threads:[~2024-08-17 8:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 11:17 bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path Alvaro Ramirez
2024-08-04 8:06 ` Eli Zaretskii
2024-08-05 9:45 ` Andrea Corallo
[not found] ` <d75b2eb4e45413d468c15f4d6e8c3d0ce568d28ddbf7a828a4f917f29e54cbcb@mu.id>
2024-08-05 14:34 ` Alvaro Ramirez
2024-08-17 8:53 ` Eli Zaretskii [this message]
2024-08-17 9:27 ` Alvaro Ramirez
2024-10-01 20:31 ` Alvaro Ramirez
2024-10-01 21:17 ` Stefan Kangas
2024-10-02 10:55 ` Alvaro Ramirez
2024-10-02 21:32 ` Stefan Kangas
2024-10-03 8:19 ` Alvaro Ramirez
2024-10-03 8:23 ` Alvaro Ramirez
2024-10-03 14:57 ` Visuwesh
2024-10-03 17:37 ` Alvaro Ramirez
2024-10-09 17:31 ` Alvaro Ramirez
2024-10-12 11:33 ` Eli Zaretskii
2024-10-12 18:27 ` Alvaro Ramirez
2024-10-19 7:58 ` Eli Zaretskii
2024-10-19 8:54 ` Alvaro Ramirez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=868qwv4jjj.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72272@debbugs.gnu.org \
--cc=acorallo@gnu.org \
--cc=alvaro@xenodium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).