From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64055: Implementation of modifying VC change comments for Git Date: Sat, 19 Oct 2024 13:28:31 +0300 Message-ID: <868qukl73k.fsf@gnu.org> References: <874j59wym3.fsf@melete.silentflame.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4533"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Morgan.J.Smith@outlook.com, 64055@debbugs.gnu.org, dgutov@yandex.ru To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 19 12:30:01 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t26if-0000zF-92 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Oct 2024 12:30:01 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t26iK-0006XM-Or; Sat, 19 Oct 2024 06:29:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t26iJ-0006XA-83 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:29:39 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t26iI-0002Ed-VE for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:29:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=MFU1dnMqwOgf5sywjmzle1jnGVJHB9xwAZN1Txb4lEY=; b=lGHXRL4a27EawmIxdnojHPX14czrRwDhT6LarHc1D1DYQ7xg2Cgzhul1R8utoTs1Ev1YUDs7JUloe5lmp2P552BYWKY9ViekHm55VOR0hWNHX5hyFevWNUMma9sRtSLlwG6BdbnHCg8P1gVg673WQrTOJIL/8zm3e0EVhPdHQITPLNFBMTl+s+Y3vY4GQn2kmauZ+Ml8ghdV+sBz12wNbiTtXNNOkjHUyC4uI+ZMnmIylo/L0w7Dh9iLGoiuejzbw5Oc4gCwDvSp4kZu4+wvhxN386wicUYDO9ZlV2QM3Sosy8XsmUm8XXDKhvT/mzl+ZUA6nBw5Xz1R/MgdnxmUHA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t26ig-0008G6-8J for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2024 06:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2024 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64055 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64055-submit@debbugs.gnu.org id=B64055.172933374731632 (code B ref 64055); Sat, 19 Oct 2024 10:30:02 +0000 Original-Received: (at 64055) by debbugs.gnu.org; 19 Oct 2024 10:29:07 +0000 Original-Received: from localhost ([127.0.0.1]:41559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t26hn-0008E8-52 for submit@debbugs.gnu.org; Sat, 19 Oct 2024 06:29:07 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t26hk-0008Db-W6 for 64055@debbugs.gnu.org; Sat, 19 Oct 2024 06:29:05 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t26hH-00026g-8F; Sat, 19 Oct 2024 06:28:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=MFU1dnMqwOgf5sywjmzle1jnGVJHB9xwAZN1Txb4lEY=; b=IIwDnZ2NSeTr eOu50nM4saL4wVem10AUap+NeKxmJqJKd03oF9QHAYXH5EyfBvlc3twYkWBKcT31RlQRkWlM6SOo2 wPkglG52WjAU2nnjSHUDVzG48m/Uu+AvIR/6aOg5MGk7AFX8g91fjM3OsPECOlr9qSkV6LxeckDHa IaZh2cHOWMv7IkwUmOf1j8Q976WWGNCG/8XiEjvtrJLEYdO3ctLFQLsUXxUW4PwSDh4kfy4OFRxe9 Dgqemv6f2JMs0rIN7Jbq4TnBsiw4cFrmzMD5gthRtuu/EsX11BORc5WmWVGmWzn5WA556fOkzrkcO vYSK2HwD079IlXU+Hj3g1g==; In-Reply-To: <874j59wym3.fsf@melete.silentflame.com> (message from Sean Whitton on Fri, 18 Oct 2024 17:26:28 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293867 Archived-At: > From: Sean Whitton > Cc: Dmitry Gutov , Morgan Smith > Date: Fri, 18 Oct 2024 17:26:28 +0800 > > This patch is the rest of this feature. Eli, would you kindly test on > MS-Windows, please? Just try to edit the message for an unpushed git > commit and add some Unicode, and see if it works correctly. I'm supposed to type 'e' in the log buffer, edit the comment, then type "C-c C-c"? Or should I do something else? When I do the above, I get an error message: vc-do-command: Failed (status 128): git --no-pager commit --only --allow-empty -F c:/Users/EliZ/AppData/Local/Temp/git-msgWaNflu and the *vc* buffer says: fatal: No paths with --include/--only does not make sense. It's possible my Git is very old, but shouldn't this command work with old versions as well?