From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#75401: 30.0.92; eglot-shutdown does not restore Flymake mode line indicator Date: Thu, 09 Jan 2025 09:24:47 +0200 Message-ID: <868qrk30w0.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25973"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 75401@debbugs.gnu.org To: Jake , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , sbaugh@janestreet.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 09 08:25:18 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tVmus-0006cj-Cv for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Jan 2025 08:25:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tVmuf-0007iB-J1; Thu, 09 Jan 2025 02:25:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVmuc-0007fu-J5 for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 02:25:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tVmuc-0005w4-9r for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 02:25:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-version:References:In-Reply-To:From:Date:To:Subject; bh=RM50gYcLlht80td6OKsKGJ0xiSRcon0Th2OzPm9p2O8=; b=vIj7uDkHUNavEMynif82z/cY0hitmh0WhUaSAjWrSt/6P37q6JVAydWPyUTwikYLuVui1uiaG+CgkS8SJ9k/Tyyka9ckcYDTn8CeUJE1bMeIMbsNUjHYsgLOCyZmW3BLw9WZkXKBf9gBflmybcXetfDCRqxellajeC9ja9kEoeeO/znxVSgF44ttQ8YC2N2UbEoT+AlnVjuhk2yv0jOFjWzTaHJszJY4JKihdlRtfVlyANl91p0G7D6RmQN/t/daGDrFg38xQ+O0dnmU2W3aOYPNuHSjTpOnYcWfIMNiudKjCCvNZbKZxlW4RadnbretnpAL+Ifo2nueAgpmEQAevQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tVmuc-0006n0-2q for bug-gnu-emacs@gnu.org; Thu, 09 Jan 2025 02:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jan 2025 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 75401 X-GNU-PR-Package: emacs Original-Received: via spool by 75401-submit@debbugs.gnu.org id=B75401.173640750026085 (code B ref 75401); Thu, 09 Jan 2025 07:25:02 +0000 Original-Received: (at 75401) by debbugs.gnu.org; 9 Jan 2025 07:25:00 +0000 Original-Received: from localhost ([127.0.0.1]:50209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tVmuZ-0006mf-Qr for submit@debbugs.gnu.org; Thu, 09 Jan 2025 02:25:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46724) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tVmuW-0006mR-JK for 75401@debbugs.gnu.org; Thu, 09 Jan 2025 02:24:57 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tVmuP-0005uz-V5; Thu, 09 Jan 2025 02:24:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=RM50gYcLlht80td6OKsKGJ0xiSRcon0Th2OzPm9p2O8=; b=i0g0+2txkrWY0x9llkoi YOF0hibyzehbvEbhOTMLjAh2na+HMoifY+wXmWkXL+b2cOqjanF95ZVS+mm/OyGd2PeYc4Lek8eC/ 3PgJELSDJ94R6jJ1lDkXDB9ZrAHJOFUbjJ+QIdPBTRQh2NVerylIo8nFd+/w87rQXTUyD8U4GCze+ SovMu1oeEFp/dJgA7twAw4eS7SlS974t2JCZdgaGhsli6osyzuxxGCpxn7xeL87gE1lQEywDMVQ4n MU/8cI8/tSeDS8MSNjnCntykLzVey5nyYG4tTALFcpi+rV2oYIVKKyJwZwfXDRRIGugZg1v4HJ0uV NvjhliGoo6MWWA==; In-Reply-To: (message from Jake on Mon, 6 Jan 2025 11:52:54 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298809 Archived-At: > From: Jake > Date: Mon, 6 Jan 2025 11:52:54 +0000 > > This bug relates to Eglot and Flymake. Demonstrating it requires a language server program. I don't think > it matters which, but I will give an example using python-mode and python-lsp-server (pylsp). > > 1. emacs -Q > > 2. Write the scratch buffer contents to a file with a python extension: C-x C-w /tmp/test.py > > 3. M-x flymake-mode > Note the Flymake indicator in the mode line is > `Flymake:!` > indicating that all backends are disabled [1]. > > 4. M-x eglot > Note the Flymake indicator in the mode line changed because the LSP is providing Flymake diagnostic > backends (I think they are pyflakes and pycodestyle in the case of pylsp). The mode line looks like: > `Flymake[1 8]` > indicating 1 error and 8 warnings. > > 5. M-x eglot-shutdown > Note the Flymake indicator is now > `Flymake[0 0]` > indicating no errors and no warnings. > > According to the manual [2]: > "Turning off Eglot means that it... restores the original values of the Emacs variables that Eglot changed > when it was turned on." > So the Flymake indicator should have returned to > `Flymake:!` > > Thanks > Jake > > [1] www.gnu.org/software/emacs/manual/html_node/flymake/Mode-line-status.html > [2] www.gnu.org/software/emacs/manual/html_node/eglot/Shutting-Down-LSP-Servers.html Spencer and João, could you please look into this issue?