unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jake <jforst.mailman@gmail.com>,
	"João Távora" <joaotavora@gmail.com>,
	sbaugh@janestreet.com
Cc: 75401@debbugs.gnu.org
Subject: bug#75401: 30.0.92; eglot-shutdown does not restore Flymake mode line indicator
Date: Thu, 09 Jan 2025 09:24:47 +0200	[thread overview]
Message-ID: <868qrk30w0.fsf@gnu.org> (raw)
In-Reply-To: <CAJqVjv-A1BrTPQr3acr32HiXO_zjffE3XVKjaZ8Jjrwko4O4eA@mail.gmail.com> (message from Jake on Mon, 6 Jan 2025 11:52:54 +0000)

> From: Jake <jforst.mailman@gmail.com>
> Date: Mon, 6 Jan 2025 11:52:54 +0000
> 
> This bug relates to Eglot and Flymake.  Demonstrating it requires a language server program.  I don't think
> it matters which, but I will give an example using python-mode and python-lsp-server (pylsp).
> 
> 1. emacs -Q
> 
> 2. Write the scratch buffer contents to a file with a python extension: C-x C-w /tmp/test.py
> 
> 3. M-x flymake-mode
> Note the Flymake indicator in the mode line is
> `Flymake:!`
> indicating that all backends are disabled [1].
> 
> 4. M-x eglot
> Note the Flymake indicator in the mode line changed because the LSP is providing Flymake diagnostic
> backends (I think they are pyflakes and pycodestyle in the case of pylsp). The mode line looks like:
> `Flymake[1 8]`
> indicating 1 error and 8 warnings.
> 
> 5. M-x eglot-shutdown
> Note the Flymake indicator is now
> `Flymake[0 0]`
> indicating no errors and no warnings.
> 
> According to the manual [2]:
> "Turning off Eglot means that it... restores the original values of the Emacs variables that Eglot changed
> when it was turned on."
> So the Flymake indicator should have returned to
> `Flymake:!`
> 
> Thanks
> Jake
> 
> [1] www.gnu.org/software/emacs/manual/html_node/flymake/Mode-line-status.html
> [2] www.gnu.org/software/emacs/manual/html_node/eglot/Shutting-Down-LSP-Servers.html

Spencer and João, could you please look into this issue?





      reply	other threads:[~2025-01-09  7:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-06 11:52 bug#75401: 30.0.92; eglot-shutdown does not restore Flymake mode line indicator Jake
2025-01-09  7:24 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=868qrk30w0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=75401@debbugs.gnu.org \
    --cc=jforst.mailman@gmail.com \
    --cc=joaotavora@gmail.com \
    --cc=sbaugh@janestreet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).