From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61098: 29.0.60; Confusing behavior of show-paren-mode Date: Tue, 31 Jan 2023 04:37:49 +0200 Message-ID: <868d11b4-1881-db52-4c54-ccb9833bcaf6@yandex.ru> References: <877cx8ose0.fsf@zohomail.eu> <83o7qiam16.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31417"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61098@debbugs.gnu.org To: Eli Zaretskii , Rah Guzar , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 03:38:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMgXT-0007v9-7B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 03:38:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMgX6-0000Vq-TX; Mon, 30 Jan 2023 21:38:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMgX4-0000TS-OL for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 21:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMgX4-0000Lk-GK for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 21:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMgX3-0007EY-Tb for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 21:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 02:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61098 X-GNU-PR-Package: emacs Original-Received: via spool by 61098-submit@debbugs.gnu.org id=B61098.167513268027799 (code B ref 61098); Tue, 31 Jan 2023 02:38:01 +0000 Original-Received: (at 61098) by debbugs.gnu.org; 31 Jan 2023 02:38:00 +0000 Original-Received: from localhost ([127.0.0.1]:51039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMgX2-0007EJ-9z for submit@debbugs.gnu.org; Mon, 30 Jan 2023 21:38:00 -0500 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:40870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMgWz-0007E4-Iq for 61098@debbugs.gnu.org; Mon, 30 Jan 2023 21:37:58 -0500 Original-Received: by mail-ej1-f54.google.com with SMTP id me3so37653797ejb.7 for <61098@debbugs.gnu.org>; Mon, 30 Jan 2023 18:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=EGF6+LvWa6irDcmH6HXb4o7yU/qF3MXyEdzz5hNH4Do=; b=GsEXVKYLTjjkrY/7OXL5Rz1u28qT5VhaOXA41C1qsngdApN5Pc5jSZSCspux/B+eGb 1A+MgUwDQ7+1AIUcJA60m/I+9DyR6C9TSvdTeoq8zcDdlf1o0KW4gSiPpf/TnFMhuH1A dUO1SkGLqTVq1Mhlbzw+SAD4haYJaBe0tG0/olW7pNdv63d/iOYwVG1Pj3aSlEgMOnkT iu4AHVP+Dtt7iwP+ZJdxYKzJne1gb+psHd7hiEhrZPnBLEuAhu/D/nNwJ7179nUVOSW8 BIM9S4rgomF96FbSKESFoO9Dtw3LK3VfAMa820KpceRw7CsDJfvkNIVT3AU0RPFv8Cda SFfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EGF6+LvWa6irDcmH6HXb4o7yU/qF3MXyEdzz5hNH4Do=; b=fA3tFhZtb78hx9GEdCOcEyw5a2ZHSIJsSnj/lMXq0GPxJbi8zjx4sK+Dt83lxr1Kb9 o+5093hgucI13867SBkYJDvK/w+EUbXqnJMRw2WwvmVJVqjtOuqQSfRonDicfmtJ2B6r TwIDeaOgh8wcHCHFz8V+d+KjTVwnj64F6ZoJw0g5avSD0+IYWXAvzZ01m8azSYb5By/k AIOhRFC5AzuCiv42zarIdAmAxh54R2mxuivU6ntLAZTd8m4Etg0uSQKq9diXcFicgboc ihbYyrz8/C2htPQIEHfuJi6ac+ZOd0IeaihJLLP6GVq+Y005Oq2CIWxo519wPO3mAV79 sCoQ== X-Gm-Message-State: AO0yUKUMuEuvJNtym9FhHxI4IDU0Ho/fvpFMMhNjDyLwwh6Gkw/thhEo G0vxBqAF2JkzhcIax+OnjhI= X-Google-Smtp-Source: AK7set9p7y/TKNRNocW8EHODT/mzi0Dev+Nh4fr4RQ9jks+mrEDv/1r4+0RsswPBQvoA7T4hmOZJ6w== X-Received: by 2002:a17:906:18ea:b0:878:5c36:a14a with SMTP id e10-20020a17090618ea00b008785c36a14amr19035399ejf.23.1675132671554; Mon, 30 Jan 2023 18:37:51 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c2-20020a170906762200b0087851a76573sm7849683ejn.74.2023.01.30.18.37.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 18:37:50 -0800 (PST) Content-Language: en-US In-Reply-To: <83o7qiam16.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254498 Archived-At: On 28/01/2023 14:20, Eli Zaretskii wrote: > Here's the patch I promised above: Your patch modifies the part which called the show-paren-mode to set up the timer, but the timer is started unconditionally, so predicate check is inside the timer function. So it seems incorrect to me. I suggest trying the patch below. It makes sure the buffer-local value of show-paren-mode is kept buffer-local even if it matches the global one (while it's = t), so that the later check (or (local-variable-p 'show-paren-mode) ;; If not, check that the predicate matches. (buffer-match-p show-paren-predicate (current-buffer))) works correctly. diff --git a/lisp/paren.el b/lisp/paren.el index b2a79624c0f..437dc057c46 100644 --- a/lisp/paren.el +++ b/lisp/paren.el @@ -165,8 +165,8 @@ show-paren-local-mode (cond ((eq show-paren-mode (default-value 'show-paren-mode)) (unless show-paren-mode - (show-paren--delete-overlays)) - (kill-local-variable 'show-paren-mode)) + (show-paren--delete-overlays) + (kill-local-variable 'show-paren-mode))) ((not (default-value 'show-paren-mode)) ;; Locally enabled, but globally disabled. (show-paren-mode 1) ; Setup the timer.