From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#31886: 27.0.50; some face can't be customized after the recent updates Date: Mon, 18 Jun 2018 22:03:21 +0100 Message-ID: <867emv959i.fsf@gmail.com> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1529355727 30598 195.159.176.226 (18 Jun 2018 21:02:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 18 Jun 2018 21:02:07 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: 31886@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 18 23:02:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV1Hn-0007rs-5J for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 23:02:03 +0200 Original-Received: from localhost ([::1]:36887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV1Ju-0002ZU-Ef for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2018 17:04:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV1Jl-0002ZO-Ui for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:04:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV1Ji-00068T-LE for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:04:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV1Ji-00068K-Gx for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fV1Ji-00037s-5e for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:04:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jun 2018 21:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31886 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.152935582611995 (code B ref -1); Mon, 18 Jun 2018 21:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jun 2018 21:03:46 +0000 Original-Received: from localhost ([127.0.0.1]:55369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV1JS-00037O-AC for submit@debbugs.gnu.org; Mon, 18 Jun 2018 17:03:46 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fV1JR-00037D-B8 for submit@debbugs.gnu.org; Mon, 18 Jun 2018 17:03:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV1JL-0005xb-Cj for submit@debbugs.gnu.org; Mon, 18 Jun 2018 17:03:40 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fV1JL-0005xS-9S for submit@debbugs.gnu.org; Mon, 18 Jun 2018 17:03:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fV1JK-0002Wy-4A for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:03:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fV1JG-0005vQ-71 for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:03:38 -0400 Original-Received: from [195.159.176.226] (port=48597 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fV1JF-0005uT-VP for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 17:03:34 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fV1H5-00073F-69 for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2018 23:01:19 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:rRfQ1yIXfLs+VQolZonci3ycY78= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147612 Archived-At: On Mon 18 Jun 2018, Markus FFM wrote: > sorry, no -Q possible. > > options/customize emacs/faces matching > customizing/storing (up to now everythings fine) > restarting emacs > all customizations are gone. > > customizations in (compiled) init.el: > (custom-set-faces > ;; custom-set-faces was added by Custom. > ;; If you edit it by hand, you could mess it up, so be careful. > ;; Your init file should contain only one such instance. > ;; If there is more than one, they won't work right. > '(custom-comment ((t (:background "font-lock-comment-face")))) > '(custom-comment-tag ((t (:foreground "font-lock-comment-face")))) > '(font-lock-comment-face ((t (:foreground "grey42")))) > '(region ((t (:background "pale goldenrod" :distant-foreground "black"))))) This could be related to recent changes for handling of custom themes. See http://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00573.html. Does this patch fix things for you ? diff --git a/lisp/cus-face.el b/lisp/cus-face.el index 039c1fafa7..54f5d51358 100644 --- a/lisp/cus-face.el +++ b/lisp/cus-face.el @@ -342,7 +342,7 @@ custom-theme-set-faces ;; is aliased to. (if (get face 'face-alias) (setq face (get face 'face-alias))) - (if (custom--should-apply-setting theme) + (if (not (custom--should-apply-setting theme)) ;; Just update theme settings. (custom-push-theme 'theme-face face theme 'set spec) ;; Update theme settings and set the face spec.