From: Andy Moreton <andrewjmoreton@gmail.com>
To: 31886@debbugs.gnu.org
Subject: bug#31886: 27.0.50; some face can't be customized after the recent updates
Date: Mon, 18 Jun 2018 22:03:21 +0100 [thread overview]
Message-ID: <867emv959i.fsf@gmail.com> (raw)
In-Reply-To: <vaafyhro.fsf@fn.de>
On Mon 18 Jun 2018, Markus FFM wrote:
> sorry, no -Q possible.
>
> options/customize emacs/faces matching <some faces>
> customizing/storing (up to now everythings fine)
> restarting emacs
> all customizations are gone.
>
> customizations in (compiled) init.el:
> (custom-set-faces
> ;; custom-set-faces was added by Custom.
> ;; If you edit it by hand, you could mess it up, so be careful.
> ;; Your init file should contain only one such instance.
> ;; If there is more than one, they won't work right.
> '(custom-comment ((t (:background "font-lock-comment-face"))))
> '(custom-comment-tag ((t (:foreground "font-lock-comment-face"))))
> '(font-lock-comment-face ((t (:foreground "grey42"))))
> '(region ((t (:background "pale goldenrod" :distant-foreground "black")))))
This could be related to recent changes for handling of custom themes.
See http://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00573.html.
Does this patch fix things for you ?
diff --git a/lisp/cus-face.el b/lisp/cus-face.el
index 039c1fafa7..54f5d51358 100644
--- a/lisp/cus-face.el
+++ b/lisp/cus-face.el
@@ -342,7 +342,7 @@ custom-theme-set-faces
;; is aliased to.
(if (get face 'face-alias)
(setq face (get face 'face-alias)))
- (if (custom--should-apply-setting theme)
+ (if (not (custom--should-apply-setting theme))
;; Just update theme settings.
(custom-push-theme 'theme-face face theme 'set spec)
;; Update theme settings and set the face spec.
next prev parent reply other threads:[~2018-06-18 21:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 20:14 bug#31886: 27.0.50; some face can't be customized after the recent updates Markus FFM
2018-06-18 21:03 ` Andy Moreton [this message]
2018-06-19 20:02 ` bug#31886: Acknowledgement (27.0.50; some face can't be customized after the recent updates)^ markusffm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=867emv959i.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=31886@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).