From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#40225: 27.0.90; abort with apparent stack explosion in lsp-mode Date: Fri, 11 Feb 2022 10:34:10 +0200 Organization: LINKOV.NET Message-ID: <867da151g5.fsf@mail.linkov.net> References: <87mu844jm0.fsf@notcom.org> <83mu849zjc.fsf@gnu.org> <835zer9cj9.fsf@gnu.org> <8600e733-d75a-3d8f-897d-2eb3ca6bb59d@notcom.org> <83h7y41pxb.fsf@gnu.org> <871r0bdw4q.fsf@gnus.org> <20220210090948.5nnlwnsa2qmmjmmy@donburi.himad.notcom.org> <86a6eyr3lr.fsf@mail.linkov.net> <20220210194910.klhkk7waxiaiwdti@donburi.himad.notcom.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2520"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 40225@debbugs.gnu.org To: Valtteri Vuorikoski Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 11 09:51:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIRea-0000Tf-8s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Feb 2022 09:51:44 +0100 Original-Received: from localhost ([::1]:53304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIReY-0005fC-9I for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Feb 2022 03:51:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIRZ4-0000zE-Ez for bug-gnu-emacs@gnu.org; Fri, 11 Feb 2022 03:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36095) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nIRZ4-0004CE-4W for bug-gnu-emacs@gnu.org; Fri, 11 Feb 2022 03:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nIRZ3-0001uW-VE for bug-gnu-emacs@gnu.org; Fri, 11 Feb 2022 03:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Feb 2022 08:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 40225-submit@debbugs.gnu.org id=B40225.16445691507313 (code B ref 40225); Fri, 11 Feb 2022 08:46:01 +0000 Original-Received: (at 40225) by debbugs.gnu.org; 11 Feb 2022 08:45:50 +0000 Original-Received: from localhost ([127.0.0.1]:58222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRYs-0001tt-JR for submit@debbugs.gnu.org; Fri, 11 Feb 2022 03:45:50 -0500 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nIRYq-0001td-Rq for 40225@debbugs.gnu.org; Fri, 11 Feb 2022 03:45:49 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1B581E000F; Fri, 11 Feb 2022 08:45:37 +0000 (UTC) In-Reply-To: <20220210194910.klhkk7waxiaiwdti@donburi.himad.notcom.org> (Valtteri Vuorikoski's message of "Thu, 10 Feb 2022 21:49:10 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:226656 Archived-At: >> > So with regard to the subject of this issue I think it's fine to close >> > this. Not having tab-line-mode call tab-line-tabs-buffer-list-function >> > on pretty much every possible event might be a worthwhile improvement >> > at some point though (I haven't checked whether things improved in >> > Emacs 28). >> >> Pretty much every event can kill buffers, and the list of buffers >> displayed on the tab line should reflect the change of the buffer list. >> The existing optimization takes care only to not redraw the tab line >> on every event when the buffer list is unchanged. > > Sounds like the elegant solution here could be a hook that runs when > buffers are created/killed/renamed. I wouldn't call it quite elegant but indeed this is a possible optimization by tracking changes in the buffer list via buffer-list-update-hook. Patches welcome from anyone who has problems with the current implementation.