From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60559: 29.0.60; "Cannot activate tree-sitter" spam Date: Thu, 05 Jan 2023 09:46:48 +0200 Organization: LINKOV.NET Message-ID: <867cy1a0vj.fsf@mail.linkov.net> References: <84973.1672843723@hassadar.pretzelnet.org> <83wn62xi3k.fsf@gnu.org> <877cy2841j.fsf@gmx.net> <83mt6yxdq0.fsf@gnu.org> <87358q82fx.fsf@gmx.net> <83ilhlxz2g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2777"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 60559@debbugs.gnu.org, Stephen Berman , epg@pretzelnet.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 08:48:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDKz1-0000aB-1f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 08:48:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDKyq-0003RT-Gr; Thu, 05 Jan 2023 02:48:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDKyo-0003R5-40 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 02:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDKyn-0005yK-SM for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 02:48:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDKyn-0007fX-LU for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 02:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 07:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix notabug Original-Received: via spool by 60559-submit@debbugs.gnu.org id=B60559.167290482429286 (code B ref 60559); Thu, 05 Jan 2023 07:48:01 +0000 Original-Received: (at 60559) by debbugs.gnu.org; 5 Jan 2023 07:47:04 +0000 Original-Received: from localhost ([127.0.0.1]:50120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDKxs-0007cI-1Q for submit@debbugs.gnu.org; Thu, 05 Jan 2023 02:47:04 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDKxq-0007bn-6v for 60559@debbugs.gnu.org; Thu, 05 Jan 2023 02:47:02 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 51FAF1C0005; Thu, 5 Jan 2023 07:46:53 +0000 (UTC) In-Reply-To: <83ilhlxz2g.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 05 Jan 2023 08:41:59 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252562 Archived-At: >> >> Emacs 28 already has conf-toml-mode for TOML files, so shouldn't >> >> toml-ts-mode be handled like e.g. c-ts-mode instead of being added to >> >> auto-mode-alist? (The default value of that variable in Emacs 29 still >> >> contains an entry for conf-toml-mode, lower down than the entry for >> >> toml-ts-mode.) >> > >> > We could indeed do that for TOML files, but I believe the problem >> > raised here is more general. >> >> That may be, but the TOML case appears to be a regression, since >> visiting a TOML file in Emacs 28 displays various faces but visiting a >> TOML file in Emacs 29 without having the tree-sitter TOML grammar >> library installed displays only the default face. > > I've now made toml-ts-mode an optional one, leaving conf-toml-mode as > the default. So now non-ts users are satisfied at the expense of ts users. Why not to do the right thing: (add-to-list 'auto-mode-alist `("\\.toml\\'" . ,(if (treesit-ready-p 'toml) 'toml-ts-mode 'conf-toml-mode)))