From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#45764: icomplete in buffer completion does not work for completion-at-point Date: Mon, 27 Feb 2023 20:33:47 +0200 Organization: LINKOV.NET Message-ID: <867cw3c60k.fsf@mail.linkov.net> References: <140804236.117906.1610282126510@office.mailbox.org> <87y1y8hagm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30230"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , simon254@mailbox.org, 45764@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 27 19:36:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pWiMF-0007j9-PQ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Feb 2023 19:36:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pWiM0-00045g-4H; Mon, 27 Feb 2023 13:36:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWiLy-00042i-Em for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 13:36:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pWiLy-000553-6N for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 13:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pWiLx-0000G4-Ou for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2023 13:36:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2023 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45764 X-GNU-PR-Package: emacs Original-Received: via spool by 45764-submit@debbugs.gnu.org id=B45764.1677522911910 (code B ref 45764); Mon, 27 Feb 2023 18:36:01 +0000 Original-Received: (at 45764) by debbugs.gnu.org; 27 Feb 2023 18:35:11 +0000 Original-Received: from localhost ([127.0.0.1]:48755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWiL9-0000Eb-4N for submit@debbugs.gnu.org; Mon, 27 Feb 2023 13:35:11 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:34535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWiL4-0000Dq-5f; Mon, 27 Feb 2023 13:35:09 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 00FF760003; Mon, 27 Feb 2023 18:34:57 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Tue, 07 Jun 2022 10:43:08 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:256893 Archived-At: close 45764 30.0.50 thanks >> `C-j' is bound to `icomplete-force-complete-and-exit', and it calls >> `minibuffer-force-complete-and-exit' unconditionally, which deletes the >> buffer contents. > > There are 2 problems, both of which stem from the fact that the code has > not been adjusted to the case where it's working in a normal buffer > rather than in the minibuffer: > - it calls `minibuffer-exit` which is wrong for in-buffer completion > (it should probably exit `completion-in-region-mode` instead). > - it assumes the area of completion is the whole buffer (it should > probably use `icomplete--field-end/beg`). This is fixed now in master, and with these fixes works quite nicely.